After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662711 - Power item in message tray
Power item in message tray
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: power
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Richard Hughes
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2011-10-25 19:43 UTC by William Jon McCann
Modified: 2011-10-26 09:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
power: Make non-urgent notifications transient (1.97 KB, patch)
2011-10-25 19:45 UTC, Florian Müllner 		none Details | Review
power: Make non-urgent notifications transient (1.96 KB, patch)
2011-10-25 19:48 UTC, Florian Müllner 		committed Details | Review

Description William Jon McCann 2011-10-25 19:43:05 UTC 
After moving the power code to gnome-settings-daemon we now get Power notifications showing up in the message tray. This shouldn't happen.

Non-critical warnings should be transient and critical warnings should be urgent.

In general, we don't want the OS to be putting items in the tray that don't have an app associated with them.
Comment 1 Florian Müllner 2011-10-25 19:45:37 UTC 
Created attachment 199962 [details] [review]
power: Make non-urgent notifications transient

gnome-power-manager used to do that, but apparently the change got
lost in the transition to gnome-settings-daemon.
Comment 2 Florian Müllner 2011-10-25 19:48:45 UTC 
Created attachment 199963 [details] [review]
power: Make non-urgent notifications transient

Sorry, stupid copy+paste error
Comment 3 Bastien Nocera 2011-10-26 09:35:59 UTC 
Review of attachment 199963 [details] [review]:

Looks correct. Could you add a link to the original code (from gnome-power-manager) in the commit as well?
Comment 4 Florian Müllner 2011-10-26 09:42:32 UTC 
Attachment 199963 [details] pushed as 6e0671d - power: Make non-urgent notifications transient

(In reply to comment #3)
> Looks correct. Could you add a link to the original code (from
> gnome-power-manager) in the commit as well?

Sure, I've added a link to the corresponding g-p-m commit before pushing.