After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662662 - Re-disable GLib deprecated
Re-disable GLib deprecated
Status: RESOLVED OBSOLETE
Product: empathy
Classification: Core
Component: General
2.33.x
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-10-25 09:47 UTC by Guillaume Desmottes
Modified: 2012-04-23 12:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Depends on GLib 2.31.0 (693 bytes, patch)
2011-10-25 13:54 UTC, Guillaume Desmottes 		accepted-commit_after_freeze Details | Review
empathy-chat: disable GLib deprecation (936 bytes, patch)
2011-10-25 13:54 UTC, Guillaume Desmottes 		accepted-commit_after_freeze Details | Review
Revert "Disable GLib deprecation warnings for now" (1.06 KB, patch)
2011-10-25 13:54 UTC, Guillaume Desmottes 		accepted-commit_after_freeze Details | Review
stop using g_thread_init (3.68 KB, patch)
2011-10-25 13:54 UTC, Guillaume Desmottes 		committed Details | Review
Allocate GMutex on the stack (9.77 KB, patch)
2011-10-25 13:54 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2011-10-25 09:47:18 UTC 
I'm going to disable GLib deprecation warnings in master. I don't want to bump the dep, and so makes things harder for contributors, without good reason. But we should re-enable this warning during this cycle.
Comment 1 Guillaume Desmottes 2011-10-25 13:54:12 UTC 
Created attachment 199933 [details] [review]
Depends on GLib 2.31.0

We need it to replace some deprecated API.
Comment 2 Guillaume Desmottes 2011-10-25 13:54:15 UTC 
Created attachment 199934 [details] [review]
empathy-chat: disable GLib deprecation

Thanks GLib for deprecating GCompletion without providing a replacement...
Comment 3 Guillaume Desmottes 2011-10-25 13:54:18 UTC 
Created attachment 199935 [details] [review]
Revert "Disable GLib deprecation warnings for now"

This reverts commit 5ccd14f47a13b5a0d00a48ec85b4c9dab6eb3bc9.
Comment 4 Guillaume Desmottes 2011-10-25 13:54:21 UTC 
Created attachment 199936 [details] [review]
stop using g_thread_init

It has been deprecated in GLib 2.31.
Comment 5 Guillaume Desmottes 2011-10-25 13:54:24 UTC 
Created attachment 199937 [details] [review]
Allocate GMutex on the stack

g_mutex_new() has been deprecated in GLib 2.31.
Comment 6 Danielle Madeley 2011-10-25 22:14:29 UTC 
Review of attachment 199933 [details] [review]:

++ but can this wait until after Friday?
Comment 7 Danielle Madeley 2011-10-25 22:15:21 UTC 
Review of attachment 199934 [details] [review]:

::: libempathy-gtk/empathy-chat.c
@@ +32,3 @@
 
+/* for GCompletion */
+#undef G_DISABLE_DEPRECATED

Do we still need this?
Comment 8 Danielle Madeley 2011-10-25 22:15:46 UTC 
Review of attachment 199935 [details] [review]:

++
Comment 9 Danielle Madeley 2011-10-25 22:15:46 UTC 
Review of attachment 199935 [details] [review]:

++
Comment 10 Danielle Madeley 2011-10-25 22:17:00 UTC 
Review of attachment 199936 [details] [review]:

++
Comment 11 Danielle Madeley 2011-10-25 22:19:32 UTC 
Review of attachment 199937 [details] [review]:

++
Comment 12 Guillaume Desmottes 2011-10-26 07:28:09 UTC 
(In reply to comment #6)
> Review of attachment 199933 [details] [review]:
> 
> ++ but can this wait until after Friday?

Sure; I'm not planning to merge it right now.
Comment 13 Guillaume Desmottes 2012-04-05 13:36:32 UTC 
Merged to master. I didn't bump GLIB_VERSION_MIN_REQUIRED as we still use GValueArray which has been deprecated as well.

Attachment 199936 [details] pushed as ee2e583 - stop using g_thread_init
Attachment 199937 [details] pushed as 2c3892e - Allocate GMutex on the stack
Comment 14 Guillaume Desmottes 2012-04-23 12:03:57 UTC 
Closing this bug. The last blocking bits is GValueArray which are tracked down in bug #673843