After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662655 - Support Opacity for LinearGradientBrush and RadialGradientBrush elements
Support Opacity for LinearGradientBrush and RadialGradientBrush elements
Status: RESOLVED FIXED
Product: libgxps
Classification: Platform
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: libgxps maintainers
libgxps maintainers
Depends on:
Blocks:
 
 
Reported: 2011-10-25 06:06 UTC by Jason Crain
Modified: 2011-11-01 11:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
adds Opacity support for LinearGradientBrush and RadialGradientBrush elements (1.93 KB, patch)
2011-10-25 06:06 UTC, Jason Crain 		none Details | Review
example XPS document showing LinearGradientBrush and RadialGradientBrush with Opacity (2.96 KB, application/octet-stream)
2011-10-25 06:07 UTC, Jason Crain 		  Details
adds Opacity support for LinearGradientBrush and RadialGradientBrush elements, uses g_ascii_strtod (1.94 KB, patch)
2011-10-27 05:17 UTC, Jason Crain 		committed Details | Review

Description Jason Crain 2011-10-25 06:06:26 UTC 
Created attachment 199897 [details] [review]
adds Opacity support for LinearGradientBrush and RadialGradientBrush elements

Included patch adds Opacity support for LinearGradientBrush and RadialGradientBrush elements.
Comment 1 Jason Crain 2011-10-25 06:07:31 UTC 
Created attachment 199898 [details]
example XPS document showing LinearGradientBrush and RadialGradientBrush with Opacity
Comment 2 Christian Persch 2011-10-25 18:46:37 UTC 
+ brush->opacity = g_strtod (values[i], NULL);

Wouldn't it be better to use g_ascii_strtod here?
Comment 3 Jason Crain 2011-10-27 05:16:07 UTC 
I cannot get this to produce unexpected results by changing the locale, but yes I agree that g_ascii_strtod would be better.
Comment 4 Jason Crain 2011-10-27 05:17:22 UTC 
Created attachment 200077 [details] [review]
adds Opacity support for LinearGradientBrush and RadialGradientBrush elements, uses g_ascii_strtod
Comment 5 Carlos Garcia Campos 2011-11-01 11:55:10 UTC 
Review of attachment 200077 [details] [review]:

Pushed to git master. Thanks!