After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662647 - gcr-viewer fails to compile
gcr-viewer fails to compile
Status: RESOLVED FIXED
Product: gcr
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-10-25 01:05 UTC by Travis Reitter
Modified: 2019-02-22 11:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Travis Reitter 2011-10-25 01:05:50 UTC 
git master fails to build gcr-viewer because it isn't linked against GLib (as it should be).

The fix is trivial:

diff --git a/gcr/Makefile.am b/gcr/Makefile.am
index 8727de9..a3bb469 100644
--- a/gcr/Makefile.am
+++ b/gcr/Makefile.am
@@ -283,6 +283,7 @@ gcr_viewer_SOURCES = \
        gcr-viewer-tool.c
 
 gcr_viewer_CFLAGS = \
+       $(GLIB_CFLAGS) \
        $(GTK_CFLAGS) \
        -DLOCALEDIR=\""$(datadir)/locale"\" \
        -DGCR_API_SUBJECT_TO_CHANGE
@@ -290,6 +291,7 @@ gcr_viewer_CFLAGS = \
 gcr_viewer_LDADD = \
        $(builddir)/libgcr-$(GCR_MAJOR).la \
        $(top_builddir)/gck/libgck-@GCK_MAJOR@.la \
+       $(GLIB_LIBS) \
        $(GTK_LIBS)
 
 # ------------------------------------------------------------------
Comment 1 Stef Walter 2011-11-01 13:33:28 UTC 
Thanks. I wonder why it didn't fail for me :S

Committed to git gcr master, and gnome-keyring gnome-3-2 (since gcr is split out now).