After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662629 - notebook: update tab area allocation when switching page
notebook: update tab area allocation when switching page
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkNotebook
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 666246 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-10-24 17:19 UTC by Cosimo Cecchi
Modified: 2011-12-22 00:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
notebook: update tab area allocation when switching page (1.51 KB, patch)
2011-10-24 17:19 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2011-10-24 17:19:37 UTC 
See patch
Comment 1 Cosimo Cecchi 2011-10-24 17:19:39 UTC 
Created attachment 199849 [details] [review]
notebook: update tab area allocation when switching page

When the active page is switched, it's important
gtk_notebook_pages_allocate() is called after the bulk of
gtk_notebook_real_switch_page() is run, as the former allocates a
different space according to the currently active tab, which is set by
the latter.
gtk_notebook_pages_allocate() already calls gtk_notebook_redraw_tabs()
when the allocation changes, so just move its call down to
gtk_notebook_real_switch_page() to fix the bug.
Comment 2 Matthias Clasen 2011-10-24 17:38:01 UTC 
Review of attachment 199849 [details] [review]:

Looks plausible, and fixes my issue. Thanks !
Comment 3 Cosimo Cecchi 2011-10-24 17:47:28 UTC 
Attachment 199849 [details] pushed as ccdc3c1 - notebook: update tab area allocation when switching page

Pushed to master.
Comment 4 Matthias Clasen 2011-12-22 00:18:57 UTC 
*** Bug 666246 has been marked as a duplicate of this bug. ***