After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662616 - We should set mime type when setting an EContact's photo
We should set mime type when setting an EContact's photo
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: e-d-s backend
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2011-10-24 14:56 UTC by Raul Gutierrez Segales
Modified: 2011-10-27 00:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.57 KB, patch)
2011-10-26 15:18 UTC, Raul Gutierrez Segales 		accepted-commit_now Details | Review

Description Raul Gutierrez Segales 2011-10-24 14:56:02 UTC 
See mcrha's comment about good e-d-s citizenship and setting mime types:

https://bugzilla.gnome.org/show_bug.cgi?id=652178#c34

Currently, we just skip setting it:

http://git.gnome.org/browse/folks/tree/backends/eds/lib/edsf-persona-store.vala#n1238

We should use e-d-s utility methods to figure out the mime-type and set it accordingly.
Comment 1 Raul Gutierrez Segales 2011-10-26 15:18:33 UTC 
Created attachment 200027 [details] [review]
patch
Comment 2 Travis Reitter 2011-10-26 16:42:01 UTC 
Review of attachment 200027 [details] [review]:

Looks good to me
Comment 3 Raul Gutierrez Segales 2011-10-27 00:06:51 UTC 
Thanks for the review. Merged:

commit fc5d0617564c77ed7e48c9a40b05930bb05aff59
Author: Raul Gutierrez Segales <rgs@collabora.co.uk>
Date:   Wed Oct 26 16:16:23 2011 +0100

    e-d-s: set content type on ContactPhotos
    
    Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=662616