After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662615 - [0.11] build failure due to printf format compiler warnings on OSX 64 bit
[0.11] build failure due to printf format compiler warnings on OSX 64 bit
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.11.x
Other Mac OS
: Normal normal
: 0.11.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-10-24 14:54 UTC by Matej Knopp
Modified: 2012-02-20 15:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fixes build warnings/errors (95.60 KB, application/octet-stream)
2011-10-24 14:54 UTC, Matej Knopp
  Details
Fix build for OS X (57.58 KB, patch)
2011-11-21 19:33 UTC, Matej Knopp
committed Details | Review
Fix matroskademux (7.16 KB, patch)
2011-11-30 17:12 UTC, Matej Knopp
none Details | Review
Fix matroskademux (8.35 KB, patch)
2012-01-14 07:04 UTC, Matej Knopp
committed Details | Review
Another one (2.74 KB, patch)
2012-01-26 11:52 UTC, Matej Knopp
none Details | Review

Description Matej Knopp 2011-10-24 14:54:20 UTC
Created attachment 199834 [details]
fixes build warnings/errors

OS X 64bit
Comment 1 Matej Knopp 2011-11-21 19:33:27 UTC
Created attachment 201854 [details] [review]
Fix build for OS X
Comment 2 Tim-Philipp Müller 2011-11-22 01:42:40 UTC
Pushed, thanks for the patch!

 commit 736a484129bef7eb1c348e1977bb9ed59b80c6c2
 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
 Date:   Tue Nov 22 01:40:39 2011 +0000

    More printf format warning fixes

 commit 1e5dd9e3150153d35eb5843c127d11d56b410a32
 Author: Matej Knopp <matej.knopp@gmail.com>
 Date:   Mon Nov 21 20:31:31 2011 +0100

    Fix printf format compiler warnings on OS X / 64bit
    
    https://bugzilla.gnome.org/show_bug.cgi?id=662615
Comment 3 Matej Knopp 2011-11-30 17:12:04 UTC
Created attachment 202462 [details] [review]
Fix matroskademux
Comment 4 Matej Knopp 2012-01-14 07:04:19 UTC
Created attachment 205251 [details] [review]
Fix matroskademux
Comment 5 Matej Knopp 2012-01-26 11:52:11 UTC
Created attachment 206170 [details] [review]
Another one
Comment 6 Vincent Penquerc'h 2012-01-31 13:36:22 UTC
Are you sure about this one ?
The first hunk (which doesn't apply anymore, that's why I looked in more detail) changes %d to % G_GSIZE_FORMAT for a variable of type gint, not gsize, and it doesn't seem to have changed types since 2008. Does this really break on MacOS ?
Comment 7 Matej Knopp 2012-01-31 13:46:59 UTC
Where exactly is that?

gstmultiudpsink.c
  hunk 1 - size is gsize
  hunk 2 - size is gsize
  hunk 3 - size is gsize

gstudpsrc.c
  hunk 1 - ret is gssize
  hunk 2 - port is guint16
  hunk 3 - src->socket is GSocket
Comment 8 Matej Knopp 2012-01-31 13:49:38 UTC
http://cgit.freedesktop.org/gstreamer/gst-plugins-good/tree/gst/udp/gstmultiudpsink.c?h=0.11
line 445 is where size is declared
Comment 9 Vincent Penquerc'h 2012-01-31 14:05:04 UTC
Ah, 0.11. Nevermind. Changing bug title then.