After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662574 - Update to unbreak GTK+/GDK deprecations
Update to unbreak GTK+/GDK deprecations
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2011-10-24 04:32 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2011-10-25 13:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
frames: Don't use deprecated API to grab pointer position (1.68 KB, patch)
2011-10-24 04:32 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
tabpopup: Convert to gtkgrid (2.16 KB, patch)
2011-10-24 04:32 UTC, Jasper St. Pierre (not reading bugmail) 		needs-work Details | Review
theme-viewer: Hack out the handlebox (1.30 KB, patch)
2011-10-24 04:32 UTC, Jasper St. Pierre (not reading bugmail) 		needs-work Details | Review
theme-viewer: Gridify the table (4.20 KB, patch)
2011-10-24 04:32 UTC, Jasper St. Pierre (not reading bugmail) 		needs-work Details | Review
theme-viewer: Un-v/h-ify boxes (2.36 KB, patch)
2011-10-24 04:32 UTC, Jasper St. Pierre (not reading bugmail) 		reviewed Details | Review
Reverting "configure: Turn off -Werror by default" Revert "configure: Turn off -Werror by default" (964 bytes, patch)
2011-10-24 04:32 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
tabpopup: Convert to gtkgrid (2.67 KB, patch)
2011-10-24 15:17 UTC, Jasper St. Pierre (not reading bugmail) 		none Details | Review
theme-viewer: Hack out the handlebox (1.63 KB, patch)
2011-10-24 15:17 UTC, Jasper St. Pierre (not reading bugmail) 		none Details | Review
theme-viewer: Gridify the table (4.36 KB, patch)
2011-10-24 15:17 UTC, Jasper St. Pierre (not reading bugmail) 		none Details | Review
tabpopup: Update to fix GTK+ deprecations (2.88 KB, patch)
2011-10-24 21:44 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
theme-viewer: Update to fix GTK+ deprecations (6.63 KB, patch)
2011-10-24 21:44 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2011-10-24 04:32:03 UTC 
See patches.
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-10-24 04:32:06 UTC 
Created attachment 199788 [details] [review]
frames: Don't use deprecated API to grab pointer position
Comment 2 Jasper St. Pierre (not reading bugmail) 2011-10-24 04:32:08 UTC 
Created attachment 199789 [details] [review]
tabpopup: Convert to gtkgrid
Comment 3 Jasper St. Pierre (not reading bugmail) 2011-10-24 04:32:10 UTC 
Created attachment 199790 [details] [review]
theme-viewer: Hack out the handlebox
Comment 4 Jasper St. Pierre (not reading bugmail) 2011-10-24 04:32:13 UTC 
Created attachment 199791 [details] [review]
theme-viewer: Gridify the table
Comment 5 Jasper St. Pierre (not reading bugmail) 2011-10-24 04:32:15 UTC 
Created attachment 199792 [details] [review]
theme-viewer: Un-v/h-ify boxes
Comment 6 Jasper St. Pierre (not reading bugmail) 2011-10-24 04:32:18 UTC 
Created attachment 199793 [details] [review]
Reverting "configure: Turn off -Werror by default" Revert "configure: Turn off -Werror by default"

This reverts commit a26e72c452d98c5c2c68dcaa3d8117b86af1f9ce.
Comment 7 Florian Müllner 2011-10-24 07:40:25 UTC 
Review of attachment 199791 [details] [review]:

Please read up on gtk_grid_attach()
Comment 8 Florian Müllner 2011-10-24 07:40:34 UTC 
Review of attachment 199789 [details] [review]:

Please read up on gtk_grid_attach()
Comment 9 Florian Müllner 2011-10-24 07:40:57 UTC 
Review of attachment 199789 [details] [review]:

Please read up on gtk_grid_attach()
Comment 10 Florian Müllner 2011-10-24 07:43:11 UTC 
Review of attachment 199792 [details] [review]:

Looks right.

(I'd squash all patches in a "Replace deprecated Gdk/Gtk+ API" commit rather than making up words like "un-v-ify")
Comment 11 Florian Müllner 2011-10-24 07:44:02 UTC 
Review of attachment 199790 [details] [review]:

Nope.

::: src/ui/theme-viewer.c
@@ -163,3 @@
-
-  gtk_container_add (GTK_CONTAINER (handlebox),
-                     gtk_ui_manager_get_widget (ui_manager, "/ui/toolbar"));

The toolbar needs to go *somewhere*
Comment 12 Florian Müllner 2011-10-24 07:47:44 UTC 
Review of attachment 199788 [details] [review]:

Looks good.
Comment 13 Jasper St. Pierre (not reading bugmail) 2011-10-24 15:17:27 UTC 
Created attachment 199837 [details] [review]
tabpopup: Convert to gtkgrid

I briefly skimmed gtk_grid_attach and noticed similarities, so I thought it was meant to be a similar API. Guess not.
Comment 14 Jasper St. Pierre (not reading bugmail) 2011-10-24 15:17:36 UTC 
Created attachment 199838 [details] [review]
theme-viewer: Hack out the handlebox
Comment 15 Jasper St. Pierre (not reading bugmail) 2011-10-24 15:17:57 UTC 
Created attachment 199839 [details] [review]
theme-viewer: Gridify the table
Comment 16 Jasper St. Pierre (not reading bugmail) 2011-10-24 21:44:14 UTC 
Created attachment 199868 [details] [review]
tabpopup: Update to fix GTK+ deprecations

Replace the GtkTable with a GtkGrid, replace GtkH/VBox with GtkBox
Comment 17 Jasper St. Pierre (not reading bugmail) 2011-10-24 21:44:25 UTC 
Created attachment 199869 [details] [review]
theme-viewer: Update to fix GTK+ deprecations

Replace the GtkTable with a GtkGrid, replace GtkH/VBox with GtkBox
and junk a GtkHandleBox.



Updated and squashed
Comment 18 Florian Müllner 2011-10-24 22:19:47 UTC 
Review of attachment 199869 [details] [review]:

LGTM
Comment 19 Florian Müllner 2011-10-24 22:19:49 UTC 
Review of attachment 199868 [details] [review]:

LGTM
Comment 20 Florian Müllner 2011-10-24 22:19:52 UTC 
Review of attachment 199793 [details] [review]:

LGTM
Comment 21 Jasper St. Pierre (not reading bugmail) 2011-10-25 13:45:04 UTC 
Attachment 199788 [details] pushed as 70db187 - frames: Don't use deprecated API to grab pointer position
Attachment 199793 [details] pushed as 331c9aa - Reverting "configure: Turn off -Werror by default" Revert "configure: Turn off -Werror by default"
Attachment 199868 [details] pushed as 4b411ea - tabpopup: Update to fix GTK+ deprecations
Attachment 199869 [details] pushed as ec1979f - theme-viewer: Update to fix GTK+ deprecations


Thanks for reviewing