After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662456 - Delete unused variables
Delete unused variables
Status: RESOLVED FIXED
Product: gnome-contacts
Classification: Core
Component: general
unspecified
Other Linux
: Normal trivial
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-10-22 13:38 UTC by Thomas Andersen
Modified: 2011-10-24 08:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Delete unused variables (1.03 KB, patch)
2011-10-22 13:38 UTC, Thomas Andersen 		none Details | Review

Description Thomas Andersen 2011-10-22 13:38:04 UTC 
Created attachment 199722 [details] [review]
Delete unused variables

While reading the code I noticed that a few variables were duplicated in main.vala and contacts-app.vala. Browsing the logs showed that the variables were copied to contacts-app.vala and used there instead.

Their use was removed in main.vala:
http://git.gnome.org/browse/gnome-contacts/commit/src/main.vala?id=281929b6dc551eb6c14be66217bbb4f9f75b6c8e

Then copied to contacts-app.vala and used there:
http://git.gnome.org/browse/gnome-contacts/commit/src/contacts-app.vala?id=281929b6dc551eb6c14be66217bbb4f9f75b6c8e

The attached patch deletes the variables from main.vala
Comment 1 Alexander Larsson 2011-10-24 08:12:45 UTC 
commited thanks!