GNOME Bugzilla – Bug 662451
Calculate the result when the = key is pressed
Last modified: 2018-05-22 11:47:00 UTC
When I use a mouse pointer to do 2+2= I get 4, but when I use a keyboard I get 2+2= typed in the entry field. In basic mode (default), I expect normal calculator behaviour, not algebraic behaviour. After this, you have to press Enter to display the result. The expected result would be to display the result when pressing the = key, just as when you press the Enter key.
Created attachment 211504 [details] [review] Solve the result on pressing '=' also. This is my first patch. I may be wrong in my approach, please let me know in all such cases.
Review of attachment 211504 [details] [review]: Simple and to the point, it seems correct.
For this to work you must
For this to work you can't always solve when = is pressed - there are valid mathematical equations that gcalctool supports that require the '=', e.g. a=1 But, it you can probably solve using = if the display is not a valid variable name, e.g. 1+2= is unambiguously solvable (since we don't support arbitrary algebraic equations) Note the behaviour should be the same in all modes because it's not clear to the user that the behaviour should change between basic and advanced and this would lead to confusion.
Review of attachment 211504 [details] [review]: This only works with the keypad = and not the normal = key. Also note the comments in the main bug - this would break entering variables.
Would attempting to solve when the user types "==" make it easier to implement this?
(In reply to Tobias Mueller from comment #6) > Would attempting to solve when the user types "==" make it easier to > implement this? Implementation might be easier (although I'm not sure on that either), but we would still have an inconsistency between typing on the keyboard or pressing the buttons. As such, I would prefer Robert's solution from comment 4: if the display is not a variable name and the left-side of the = sign is unambiguously solvable, calculate the result. I will take a look at the code to see if I can implement that.
Adding Allan Day to provide a bit of design feedback here as: * gnome-calculator is not a document-based application, so based on the current HIG, the window title should be the application name * however, if we consider calculations "documents", the last result can be of immediate use for the user, so this might be ok to show in the window title.
My previous comment was meant for bug 527754, sorry for the noise. @Allan Day, no design feedback needed here, please remove yourself from CC, as I can't undo my action of adding you.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-calculator/issues/22.