After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662389 - [dock] Changing hide-effect at runtime doesn't work
[dock] Changing hide-effect at runtime doesn't work
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-10-21 13:27 UTC by Stefan "psYchotic" Zwanenburg
Modified: 2011-11-18 17:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix hide-effect dconf handler (2.35 KB, patch)
2011-10-21 13:29 UTC, Stefan "psYchotic" Zwanenburg
committed Details | Review

Description Stefan "psYchotic" Zwanenburg 2011-10-21 13:27:07 UTC
I ran into this problem as I was trying to implement another "hide-effect".
Steps to reproduce:
  1. Launch gnome-shell (as you usually do, such as by logging in).
  2. Make sure the dock extension is loaded.
  3. Launch dconf-editor.
  4. Change the value of the /org/gnome/shell/extensions/dock/hide-effect key.

Expected outcome: the hide-effect has been changed.
Actual outcome: the hide-effect has been left unchanged.

I've located the source of the problem to the fact that the "leave_event" and "enter_event" variables are uninitialized when first running the signal handler for the "changed" event for the dconf key mentioned above.

Please find attached a patch to solve the problem.

PS: you may see that upon changing the dconf key, your dock gets moved. This is because of a line I'm not sure is necessary, which does 'this.actor.y = 0'. However, the hide-effect is left unchanged.
Comment 1 Stefan "psYchotic" Zwanenburg 2011-10-21 13:29:58 UTC
Created attachment 199641 [details] [review]
fix hide-effect dconf handler
Comment 2 Giovanni Campagna 2011-11-18 17:39:46 UTC
Thanks a lot for your patch, pushed!