After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662338 - nm-applet password dialog shown before the shell one in some circumstances
nm-applet password dialog shown before the shell one in some circumstances
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: network-indicator
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 663169 665311 673995 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-10-20 22:19 UTC by Cosimo Cecchi
Modified: 2012-04-12 17:32 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Cosimo Cecchi 2011-10-20 22:19:13 UTC
I happen to reproduce this quite often with this peculiar circumstances, but I think this might be a more general problem when an AP is not reachable anymore.

- I often take a bus to commute to the office, and the bus waits for some minutes outside the office; I open the laptop while the bus is there, and it will connect to the office wireless
- the bus takes the road, and after a bit the office AP is not reachable anymore
- NM will lose the connection and will try to reconnect to the AP; while this happens, the indicator in the shell is in the "connecting" state (correct behaviour)
- reconnection will fail, since the AP is not reachable anymore, and NM will prompt for the wireless password
- I get the nm-applet GTK dialog for the password first; if I cancel it, I will get the shell one

I'd argue there are two bugs here:
1. the shell dialog should be shown instead of the GTK one; at no point in this process I should see two consequent dialogs asking me the same thing
2. if the AP is not reachable anymore, there's no point in asking again for the password. Connection didn't fail due to an authentication error, but because the AP signal is not in range; we should detect that and just switch to disconnected state
Comment 1 Florian Müllner 2011-10-20 22:56:21 UTC
None of this looks like a shell problem; I've talked with Dan a while ago about 1), apparently the order in which authentication agents are executed is "random" (the proper solution is to implement missing bits in the gnome-shell agent, so that nm-applet can die die die)
Comment 2 Cosimo Cecchi 2011-10-24 21:52:43 UTC
I saw another variant of this bug again; this time it was a genuine password request dialog (after having selected a network from the menu), and the GTK dialog hijacked the shell one.

(In reply to comment #1)
> None of this looks like a shell problem; I've talked with Dan a while ago about
> 1), apparently the order in which authentication agents are executed is
> "random" (the proper solution is to implement missing bits in the gnome-shell
> agent, so that nm-applet can die die die)

Is there any reason why nm-applet is needed at all in a non-fallback mode? What do we need to implement to eradicate it completely?
Comment 3 Florian Müllner 2011-10-24 22:06:05 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > None of this looks like a shell problem; I've talked with Dan a while ago about
> > 1), apparently the order in which authentication agents are executed is
> > "random" (the proper solution is to implement missing bits in the gnome-shell
> > agent, so that nm-applet can die die die)
> 
> Is there any reason why nm-applet is needed at all in a non-fallback mode? What
> do we need to implement to eradicate it completely?

VPN. Currently, each nm plugin provides its own authentication dialog and communicates with nm via pipes. It is definitively on the list of stuff-to-fix-for-3.4 ...
Comment 4 Rui Matos 2011-11-01 20:39:05 UTC
*** Bug 663169 has been marked as a duplicate of this bug. ***
Comment 5 Pierre Ossman 2011-11-14 13:51:07 UTC
I'm also getting this. As an extra bonus, entering the key into the first (GTK) dialog doesn't save it. Entering it into the second one (shell) saves it properly though. Odd...
Comment 6 Milan Bouchet-Valat 2011-12-02 09:19:57 UTC
*** Bug 665311 has been marked as a duplicate of this bug. ***
Comment 7 Pierre Ossman 2011-12-08 08:15:55 UTC
And it keeps on giving. It also manages to nuke the stored secret now and then when in this mode. Extremely annoying as it is not something you generally keep written down.
Comment 8 Milan Bouchet-Valat 2011-12-08 09:59:45 UTC
(In reply to comment #7)
> And it keeps on giving. It also manages to nuke the stored secret now and then
> when in this mode. Extremely annoying as it is not something you generally keep
> written down.
I think that the fact that it loses the secret is a different issue you reported elsewhere, please don't mix separate problems.
Comment 9 Pierre Ossman 2011-12-08 12:28:05 UTC
The other issue I reported was that it kept popping up the question. In those cases it is always filled in the secret though. I've only seen it actually lose the secret when the scenario here occurs. Could certainly be a different bug, but they seem correlated.
Comment 10 Milan Bouchet-Valat 2011-12-08 12:51:19 UTC
We're talking about bug 665680, right? You didn't mention the old nm-applet dialog appearing in that report. That would indeed be valuable information.
Comment 11 Pierre Ossman 2011-12-08 18:20:02 UTC
Bug 665680, right. But no, it does not appear. To clarify:

Bug 662338 (this bug):

 - sometimes nm-applet dialog pops up
 - when this happens, sometimes also the secret is forgotten

Bug 665680 (other bug):

 - Sometimes it starts nagging me with the gnome-shell password dialog on each and every connection. I have not (yet) seen the nm-applet dialog in these cases.


For me these things also tend to happen at different times. This bug only happens when NM has connection problems (which happens because of other NM/iwl bugs), whilst the other bug is also for "normal", well functioning connections.
Comment 12 Pierre Ossman 2011-12-22 07:28:20 UTC
Got the lost password here again. This time I kept monitoring the state of things with nm-connection-editor. The password is lost somewhere after I close the nm-applet dialog and before the gnome-shell dialog. So right now it would point at nm-applet having the bug that wipes the secret.
Comment 13 Milan Bouchet-Valat 2012-01-19 09:55:26 UTC
Pierre: Good news, I've also experienced the lost passphrase issue. I've filed it separately as Bug 668251 since I realized the present report is really about a different issue (see my report).
Comment 14 Giovanni Campagna 2012-04-12 16:52:36 UTC
*** Bug 673995 has been marked as a duplicate of this bug. ***
Comment 15 Cosimo Cecchi 2012-04-12 17:32:22 UTC
It's worth mentioning that this specific bug has been now fixed for GNOME 3.4 - you need network-manager-applet from git and gnome-shell >= 3.4.0.
I'm closing this as FIXED, since the other issues mentioned in the comments of this report have separate bugs already.