After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662319 - gtkicontheme: Make thread-safe
gtkicontheme: Make thread-safe
Status: RESOLVED WONTFIX
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-10-20 18:56 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2011-10-26 16:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtkicontheme: Make thread-safe (14.05 KB, patch)
2011-10-20 18:56 UTC, Jasper St. Pierre (not reading bugmail) 		none Details | Review
gtkicontheme: Make thread-safe (13.97 KB, patch)
2011-10-20 19:15 UTC, Jasper St. Pierre (not reading bugmail) 		none Details | Review

Description Jasper St. Pierre (not reading bugmail) 2011-10-20 18:56:20 UTC 
See patch.
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-10-20 18:56:22 UTC 
Created attachment 199568 [details] [review]
gtkicontheme: Make thread-safe
Comment 2 Jasper St. Pierre (not reading bugmail) 2011-10-20 19:15:50 UTC 
Created attachment 199570 [details] [review]
gtkicontheme: Make thread-safe

It always helps to *test* your changes, doesn't it. Attached a version
that fixes a few embarrasing typos and a thinko.
Comment 3 Matthias Clasen 2011-10-21 02:06:03 UTC 
I don't think this is needed.
You have to hold the gdk lock anyway, when calling gtk api from multiple threads.