GNOME Bugzilla – Bug 662285
Error with email -> im_addresses when updating a contact.
Last modified: 2011-10-24 15:45:04 UTC
Updating a contact will fail to update the automatic email -> im_addresses. Attaching fix.
Created attachment 199515 [details] [review] Correctly update email based im addresses during contact changes When we have already read a contact, but are updating it e.g. due to a property change there is a problem in Edsf.Persons._update_im_addressess(). Its looking at the existing personas im_addresses for already existing im addresses before adding new ones. However, they were already added there based on the email addresses last time, which means we don't add them now. The fix is simple, just look in new_im_addressess for existing im_addresses.
eh, that was the wrong patch...
Created attachment 199519 [details] [review] Correctly update email based im addresses during contact changes When we have already read a contact, but are updating it e.g. due to a property change there is a problem in Edsf.Persons._update_im_addressess(). Its looking at the existing personas im_addresses for already existing im addresses before adding new ones. However, they were already added there based on the email addresses last time, which means we don't add them now. The fix is simple, just look in new_im_addressess for existing im_addresses.
*** Bug 660665 has been marked as a duplicate of this bug. ***
Review of attachment 199519 [details] [review]: Make it so, plus an entry in NEWS please. Cheers.
Added the entry in the NEWS file and pushed this. Thanks! commit cf255636136aab4cd6673b2d963641607fe059c9 Author: Alexander Larsson <alexl@redhat.com> Date: Thu Oct 20 13:58:01 2011 +0200 Correctly update email based im addresses during contact changes When we have already read a contact, but are updating it e.g. due to a property change there is a problem in Edsf.Persons._update_im_addressess(). Its looking at the existing personas im_addresses for already existing im addresses before adding new ones. However, they were already added there based on the email addresses last time, which means we don't add them now. The fix is simple, just look in new_im_addressess for existing im_addresses. https://bugzilla.gnome.org/show_bug.cgi?id=662285