After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662285 - Error with email -> im_addresses when updating a contact.
Error with email -> im_addresses when updating a contact.
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: e-d-s backend
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
: 660665 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-10-20 12:05 UTC by Alexander Larsson
Modified: 2011-10-24 15:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Correctly update email based im addresses during contact changes (2.33 KB, patch)
2011-10-20 12:08 UTC, Alexander Larsson 		none Details | Review
Correctly update email based im addresses during contact changes (1.43 KB, patch)
2011-10-20 12:33 UTC, Alexander Larsson 		accepted-commit_now Details | Review

Description Alexander Larsson 2011-10-20 12:05:58 UTC 
Updating a contact will fail to update the automatic email -> im_addresses.
Attaching fix.
Comment 1 Alexander Larsson 2011-10-20 12:08:31 UTC 
Created attachment 199515 [details] [review]
Correctly update email based im addresses during contact changes

When we have already read a contact, but are updating it e.g. due
to a property change there is a problem in
Edsf.Persons._update_im_addressess(). Its looking at the existing
personas im_addresses for already existing im addresses before adding
new ones. However, they were already added there based on the email
addresses last time, which means we don't add them now.

The fix is simple, just look in new_im_addressess for existing
im_addresses.
Comment 2 Alexander Larsson 2011-10-20 12:30:42 UTC 
eh, that was the wrong patch...
Comment 3 Alexander Larsson 2011-10-20 12:33:18 UTC 
Created attachment 199519 [details] [review]
Correctly update email based im addresses during contact changes

When we have already read a contact, but are updating it e.g. due
to a property change there is a problem in
Edsf.Persons._update_im_addressess(). Its looking at the existing
personas im_addresses for already existing im addresses before adding
new ones. However, they were already added there based on the email
addresses last time, which means we don't add them now.

The fix is simple, just look in new_im_addressess for existing
im_addresses.
Comment 4 Alexander Larsson 2011-10-20 14:58:36 UTC 
*** Bug 660665 has been marked as a duplicate of this bug. ***
Comment 5 Philip Withnall 2011-10-20 16:24:59 UTC 
Review of attachment 199519 [details] [review]:

Make it so, plus an entry in NEWS please. Cheers.
Comment 6 Raul Gutierrez Segales 2011-10-24 15:45:04 UTC 
Added the entry in the NEWS file and pushed this. Thanks!

commit cf255636136aab4cd6673b2d963641607fe059c9
Author: Alexander Larsson <alexl@redhat.com>
Date:   Thu Oct 20 13:58:01 2011 +0200

    Correctly update email based im addresses during contact changes
    
    When we have already read a contact, but are updating it e.g. due
    to a property change there is a problem in
    Edsf.Persons._update_im_addressess(). Its looking at the existing
    personas im_addresses for already existing im addresses before adding
    new ones. However, they were already added there based on the email
    addresses last time, which means we don't add them now.
    
    The fix is simple, just look in new_im_addressess for existing
    im_addresses.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=662285