GNOME Bugzilla – Bug 662270
Window snapping buggy when using "shift" during move
Last modified: 2011-10-20 15:21:58 UTC
Created attachment 199502 [details] Desktop after shift-snapping, no keyboard or mouse key pressed... When pressing shift during a window move, then the window corners stick to other windows or borders of the screen. However, when moving a window entirely to the side and keep pressing shift, then the blue preview window shows. When one now stops pressing the mouse button, the window does not resize, but the blue preview window stays without any mouse button or key pressed... See screenshot, where I have one terminal in the background, so that one can better see the blue preview, and one terminal shift-moved to the extreme right.
Created attachment 199534 [details] [review] tiling: do not tile if moving in snap mode If we are moving in snap mode (shift pressed) we don't want to tile. We must also cancel any pending tiling if snap mode is activated during the move drag.
Review of attachment 199534 [details] [review]: Looks about right; it's probably a bit cleaner to write if (foo && !bar) /* something */ else if (bar) /* something else */ as if (bar) /* something else */ else if (foo) /* something */ ::: src/core/window.c @@ +8487,3 @@ + else if (snap) + { + window->tile_mode = META_TILE_NONE; I think this could use a small comment; you should also reset tile_monitor_number ;-)
Created attachment 199537 [details] [review] tiling: do not tile if moving in snap mode Thanks for the review Florian!
Review of attachment 199537 [details] [review]: LGTM (note: I didn't actually test the patch)
Attachment 199537 [details] pushed as 6aa4bfd - tiling: do not tile if moving in snap mode