After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662259 - drop a dead variable
drop a dead variable
Status: RESOLVED FIXED
Product: dconf
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: dconf-maint
dconf-maint
Depends on:
Blocks:
 
 
Reported: 2011-10-20 00:30 UTC by Matthias Clasen
Modified: 2011-10-31 23:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Drop a dead variable (1.16 KB, patch)
2011-10-20 00:30 UTC, Matthias Clasen
committed Details | Review

Description Matthias Clasen 2011-10-20 00:30:23 UTC
The GError in add_match_done is never used. Whats worse, it is dereferenced in the error path. 

This is the kind of thing that drives static analyzers up the wall...
Comment 1 Matthias Clasen 2011-10-20 00:30:46 UTC
Created attachment 199494 [details] [review]
Drop a dead variable

The GError in add_match_done is never used. Whats worse,
it is dereferenced in the error path.
Comment 2 Allison Karlitskaya (desrt) 2011-10-31 23:18:32 UTC
Attachment 199494 [details] pushed as a271dac - Drop a dead variable

Thanks