After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662251 - build failure with [-Werror=format-security]
build failure with [-Werror=format-security]
Status: RESOLVED WONTFIX
Product: gnome-cups-manager
Classification: Deprecated
Component: libgnomecups
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jody Goldberg
gnome[unmaintained]
Depends on:
Blocks:
 
 
Reported: 2011-10-19 22:54 UTC by Michael Biebl
Modified: 2012-02-28 15:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] Fix build failure with [-Werror=format-security] (1.30 KB, patch)
2011-10-19 22:55 UTC, Michael Biebl
none Details | Review

Description Michael Biebl 2011-10-19 22:54:35 UTC
Version: 0.2.3
Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=643424

The attached patch fixes the following build failure:

Relevant part:
>  gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I.. -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -DDATADIR=\"/usr/share\" -g -O2 -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security -Wall -c gnome-cups-request.c  -fPIC -DPIC -o .libs/gnome-cups-request.o
> gnome-cups-request.c: In function 'request_thread_main':
> gnome-cups-request.c:356:10: error: format not a string literal and no format arguments [-Werror=format-security]
> gnome-cups-request.c:367:9: error: format not a string literal and no format arguments [-Werror=format-security]
> gnome-cups-request.c:375:2: warning: value computed is not used [-Wunused-value]
> gnome-cups-request.c: In function 'gnome_cups_request_add_requested_attributes':
> gnome-cups-request.c:469:10: warning: passing argument 7 of 'ippAddStrings' from incompatible pointer type [enabled by default]
> /usr/include/cups/ipp.h:460:25: note: expected 'const char * const*' but argument is of type 'char **'
> cc1: some warnings being treated as errors
> 
> make[3]: *** [gnome-cups-request.lo] Error 1
Comment 1 Michael Biebl 2011-10-19 22:55:51 UTC
Created attachment 199491 [details] [review]
[PATCH] Fix build failure with [-Werror=format-security]
Comment 2 André Klapper 2012-02-28 15:53:19 UTC
"gnome-cups-manager" will not see active development anymore according to its
developers.
Closing this report as WONTFIX - Please feel free to reopen this bug report in
the future if anyone takes the responsibility for active development again.