After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662249 - Declare void functions as such
Declare void functions as such
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: at-spi2-core
unspecified
Other All
: Normal normal
: ---
Assigned To: Li Yuan
Depends on:
Blocks:
 
 
Reported: 2011-10-19 22:51 UTC by Matthias Clasen
Modified: 2011-10-20 10:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Declare void functions as such (868 bytes, patch)
2011-10-19 22:51 UTC, Matthias Clasen
accepted-commit_now Details | Review
Declare void functions as such (868 bytes, patch)
2011-10-20 10:27 UTC, Matthias Clasen
committed Details | Review

Description Matthias Clasen 2011-10-19 22:51:08 UTC
handle_a11y_enabled_changed was missing a 'static void', causing
static analyzers to complain about returns.
Comment 1 Matthias Clasen 2011-10-19 22:51:09 UTC
Created attachment 199490 [details] [review]
Declare void functions as such
Comment 2 Mike Gorse 2011-10-19 23:59:56 UTC
Comment on attachment 199490 [details] [review]
Declare void functions as such

Looks fine. Thanks.




>From f918cd8787e68c8f11bdde10be8b0cc632417ada Mon Sep 17 00:00:00 2001
>From: Matthias Clasen <mclasen@redhat.com>
>Date: Wed, 19 Oct 2011 18:48:25 -0400
>Subject: [PATCH] Declare void functions as such
>
>handle_a11y_enabled_changed was missing a 'static void', causing
>static analyzers to complain about returns.
>
>https://bugzilla.gnome.org/show_bug.cgi?id=662249
>---
> bus/at-spi-bus-launcher.c |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>diff --git a/bus/at-spi-bus-launcher.c b/bus/at-spi-bus-launcher.c
>index a7f2183..3133a39 100644
>--- a/bus/at-spi-bus-launcher.c
>+++ b/bus/at-spi-bus-launcher.c
>@@ -253,6 +253,7 @@ handle_get_property  (GDBusConnection       *connection,
>     return NULL;
> }
> 
>+static void
> handle_a11y_enabled_change (A11yBusLauncher *app, gboolean enabled,
>                                gboolean notify_gsettings)
> {
>-- 
>1.7.6.4
Comment 3 Matthias Clasen 2011-10-20 10:27:16 UTC
The following fix has been pushed:
f918cd8 Declare void functions as such
Comment 4 Matthias Clasen 2011-10-20 10:27:19 UTC
Created attachment 199512 [details] [review]
Declare void functions as such

handle_a11y_enabled_changed was missing a 'static void', causing
static analyzers to complain about returns.