Created attachment 199457 [details] [review]
meta-window-group: Use clutter_actor_has_effects instead of get_effects

Review of attachment 199457 [details] [review]:

Looks good, but in my opinion we should either avoid the version bump or not push the patch until mutter/gnome-shell are usable with unstable clutter.

::: configure.in
@@ +186,3 @@
 fi
 
+CLUTTER_VERSION=1.9.1

Given the general brokenness at the moment when using unstable cogl/clutter, can we not bump the requirement and #if #else the code in question for now?

Created attachment 199573 [details] [review]
meta-window-group: Use clutter_actor_has_effects if available

This avoids a potentially costly allocation on every pixmap update.



This better?

Review of attachment 199573 [details] [review]:

Looks good with "inline" removed.

::: src/compositor/meta-window-group.c
@@ +106,3 @@
+#else
+
+inline static gboolean

inline is C99

Attachment 199573 [details] pushed as 3599917 - meta-window-group: Use clutter_actor_has_effects if available

(In reply to comment #4)
> Review of attachment 199573 [details] [review]:
> 
> Looks good with "inline" removed.
> 
> ::: src/compositor/meta-window-group.c
> @@ +106,3 @@
> +#else
> +
> +inline static gboolean
> 
> inline is C99

I don't think inline is necessary here, but for reference:

 * GLib will define inline if missing, so 'static inline' is fine (header files are more complex if you care about old compilers )
 * Mutter is defined to be using C99 now

(In reply to comment #6)
>  * Mutter is defined to be using C99 now

Oh, I wasn't aware of that