After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662213 - dash: bottommost icon lacks bottom padding in some circumstances
dash: bottommost icon lacks bottom padding in some circumstances
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-10-19 16:32 UTC by Cosimo Cecchi
Modified: 2012-01-24 22:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
dash: Use the correct theme node for spacing/padding (1.03 KB, patch)
2011-10-19 21:06 UTC, Florian Müllner
committed Details | Review

Description Cosimo Cecchi 2011-10-19 16:32:31 UTC
See people.gnome.org/~cosimoc/dash.png

This is with gnome-shell 3.2.1.
Comment 1 Cosimo Cecchi 2011-10-19 16:32:51 UTC
http://people.gnome.org/~cosimoc/dash.png <- clickable link
Comment 2 Florian Müllner 2011-10-19 16:37:06 UTC
I see the problem, I'll do a patch later.
Comment 3 Florian Müllner 2011-10-19 21:06:12 UTC
Created attachment 199479 [details] [review]
dash: Use the correct theme node for spacing/padding

We consider spacing and padding in _adjustIconSize, but as we use
the theme node from an actor which is not exposed to the CSS, we
miss the "real" values - correct this.
Comment 4 Owen Taylor 2012-01-24 21:40:08 UTC
Review of attachment 199479 [details] [review]:

Looks good
Comment 5 Florian Müllner 2012-01-24 22:07:49 UTC
Attachment 199479 [details] pushed as c6e9f97 - dash: Use the correct theme node for spacing/padding