After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662091 - plugin loader: spawn new plugin loader helper after loading N plugins
plugin loader: spawn new plugin loader helper after loading N plugins
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-10-18 13:17 UTC by Tim-Philipp Müller
Modified: 2011-10-26 10:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
registry: add support for GST_REGISTRY_REUSE_PLUGIN_SCANNER=no (1.82 KB, patch)
2011-10-20 13:34 UTC, Tim-Philipp Müller
committed Details | Review

Description Tim-Philipp Müller 2011-10-18 13:17:11 UTC
In some environments (e.g. Android, or Linux in some cases) there may be quite strict limits on the number of open file descriptors / loaded libraries or some such.

It would be good if we could support a mode where we don't introspect all plugins using the same plugin loading helper, but make the helper exit after N plugins and then re-spawn a new one to introspect the next few plugins. This makes sure we don't get the plugin helper killed when loading too many plugins/libraries.
Comment 1 Tim-Philipp Müller 2011-10-20 13:34:10 UTC
Created attachment 199525 [details] [review]
registry: add support for GST_REGISTRY_REUSE_PLUGIN_SCANNER=no

Tentative patch, seems to work.

This will make sure we spawn a new plugin scanner helper for each plugin
to be introspected, which helps with making sure we don't load too many
shared objects (libs, plugins) at the same time on systems where there
is a hard limit like on Android.

FIXME: a better version would re-use the scanner for up to N times
Comment 2 Tim-Philipp Müller 2011-10-26 10:20:43 UTC
commit dd9f244f033ba3978d6ee26d9205d29fdd862d7c
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Tue Oct 18 23:19:47 2011 +0100

    registry: add support for GST_REGISTRY_REUSE_PLUGIN_SCANNER=no
    
    This will make sure we spawn a new plugin scanner helper for each plugin
    to be introspected, which helps with making sure we don't load too many
    shared objects (libs, plugins) at the same time on systems where there
    is a hard limit like on Android.
    
    A better version might re-use the scanner for up to N times, though
    it's not clear whether that would actually improve things dramatically.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=662091