After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662081 - ALT GR+Enter does not open Properties as should (ALT+Enter)
ALT GR+Enter does not open Properties as should (ALT+Enter)
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File and Folder Operations
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-10-18 10:43 UTC by florin.arjocu
Modified: 2016-03-09 13:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
files-view: added alt+return shortcut for properties (2.09 KB, patch)
2016-03-03 21:47 UTC, Joe
none Details | Review
files-view: added alt+return shortcut for properties (2.86 KB, patch)
2016-03-04 13:51 UTC, Joe
committed Details | Review

Description florin.arjocu 2011-10-18 10:43:20 UTC
Alt + Enter should open selected file/folder Properties in Nautilus. But Alt Gr+Enter does not do that. Alt GR is Alt but it can be used for specific language tasks in some conditions. Anyways, in combination with Enter it should open Properties and it's not, Nautilus acts like I only pressed Enter.
Comment 1 Mohammed Sadiq 2016-02-08 18:27:05 UTC
Nautilus currently uses Control+I to open file/folder properties.

But it would be great to have Alt+Enter instead, because this is used
in several pieces of software like EOG, evince, rhythmbox, etc, and thus to keep in resonance with other GNOME components.
Comment 2 florin.arjocu 2016-02-08 21:29:39 UTC
Actually Alt+Enter works in Nautilus. AltGr+Enter does not work and it should, it is easier to only use one hand.
Comment 3 Mohammed Sadiq 2016-02-09 01:02:11 UTC
(In reply to florin.arjocu from comment #2)
> Actually Alt+Enter works in Nautilus. AltGr+Enter does not work and it
> should, it is easier to only use one hand.

Does it? For me, neither Alt+Enter nor AltGr+Enter is working (using Nautilus 3.18.5). Also when I right click somewhere in nautilus, it shows me that the 'properties' can be opened via Control+I mnemonic, which works.

Both Alt and AltGr with Enter should (preferably) open properties.
Comment 4 florin.arjocu 2016-02-09 04:13:49 UTC
Ah, I use Ubuntu 15.10 and I only have version Nautilus 3.14.2. It means they are taking the shortcut out of Nautilus, I see no reason for that :(
Comment 5 Mohammed Sadiq 2016-02-09 04:48:36 UTC
Hm... The change happened in Nautilus 3.16+. 


This is the code from 3.14:
link: https://git.gnome.org/browse/nautilus/tree/src/nautilus-view.c?h=gnome-3-14#n7107
  /* label, accelerator */       N_("P_roperties"), "<alt>Return",

And this is the code from 3.16:
link: https://git.gnome.org/browse/nautilus/tree/src/nautilus-view.c?h=gnome-3-16#n7562
   nautilus_application_add_accelerator (app, "view.properties", "<control>i");

This file was renamed to nautilus-files-view.c in 3.18:
link: https://git.gnome.org/browse/nautilus/tree/src/nautilus-files-view.c?h=gnome-3-18#n8148
   nautilus_application_add_accelerator (app, "view.properties", "<control>i");

These links shall help newcomers to fix this bug.
Comment 6 Joe 2016-03-03 21:47:02 UTC
Created attachment 323030 [details] [review]
files-view: added alt+return shortcut for properties

With nautilus 3.16 the properties shortcut was changed from
alt+return to ctrl+i.

alt+return is a known shortcut in other applications for showing
file properties, so it was proposed to add alt+enter and altgr+enter
as shortcuts in bug 662081.

nautilus_application_add_accelerator() does not accept multiple shortcuts
per action, so I used gtk_application_set_accels_for_action() and bound
view.properties to the array open_properties.
Unfortunately, I couldn't find a reliable way to bind altgr for the
shortcut, as modifiers are dependend on the X server mapping.
Comment 7 Carlos Soriano 2016-03-04 08:41:54 UTC
Review of attachment 323030 [details] [review]:

Patch looks mostly good, you need to modify the shortcuts window to reflect this change though.
Comment 8 Joe 2016-03-04 13:51:39 UTC
Created attachment 323090 [details] [review]
files-view: added alt+return shortcut for properties

With nautilus 3.16 the properties shortcut was changed from
alt+return to ctrl+i.

alt+return is a known shortcut in other applications for showing
file properties, so it was proposed to add alt+enter and altgr+enter
as shortcuts in bug 662081.

nautilus_application_add_accelerator() does not accept multiple shortcuts
per action, so I used gtk_application_set_accels_for_action() and bound
view.properties to the array open_properties.
Also the additional shortcut was added to the shortcuts overview.
Unfortunately, I couldn't find a reliable way to bind altgr for the
shortcut, as modifiers are dependend on the X server mapping.
Comment 9 Carlos Soriano 2016-03-07 17:12:58 UTC
Review of attachment 323090 [details] [review]:

Looks good now, thanks!
Comment 10 Carlos Soriano 2016-03-07 20:12:09 UTC
Attachment 323090 [details] pushed as 91a5591 - files-view: added alt+return shortcut for properties
Comment 11 Mohammed Sadiq 2016-03-09 10:30:39 UTC
Is it really required to have the old Ctrl+I for properties? I think it can be removed so that it may be used for something else later.
Comment 12 Carlos Soriano 2016-03-09 12:22:46 UTC
(In reply to Mohammed Sadiq from comment #11)
> Is it really required to have the old Ctrl+I for properties? I think it can
> be removed so that it may be used for something else later.

The same question can be done for alt + enter, since this ctrl+i has been there for long time. So yeah, we will keep it.
Comment 13 Mohammed Sadiq 2016-03-09 13:24:14 UTC
Hm... Nice point. Hope usability testing will solve several things before Gtk4