After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662064 - Build and GCC warning fixes with glib git.
Build and GCC warning fixes with glib git.
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
: 662010 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-10-18 05:51 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2011-10-19 16:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
value.c: Don't use deprecated gvalue calls (1.24 KB, patch)
2011-10-18 05:51 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
console.c: Don't use deprecated g_thread_init() (700 bytes, patch)
2011-10-18 05:51 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
stack.c: Kill a gcc unused variable warning (1.22 KB, patch)
2011-10-18 05:51 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2011-10-18 05:51:41 UTC 
see patches.
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-10-18 05:51:42 UTC 
Created attachment 199301 [details] [review]
value.c: Don't use deprecated gvalue calls

https://bugzilla.gnome.org/show_bug.cgi?id=662010
Comment 2 Jasper St. Pierre (not reading bugmail) 2011-10-18 05:51:45 UTC 
Created attachment 199302 [details] [review]
console.c: Don't use deprecated g_thread_init()
Comment 3 Jasper St. Pierre (not reading bugmail) 2011-10-18 05:51:48 UTC 
Created attachment 199303 [details] [review]
stack.c: Kill a gcc unused variable warning
Comment 4 Jasper St. Pierre (not reading bugmail) 2011-10-18 18:59:09 UTC 
*** Bug 662010 has been marked as a duplicate of this bug. ***
Comment 5 Colin Walters 2011-10-19 16:09:57 UTC 
Review of attachment 199301 [details] [review]:

You'll need to update the configure.ac to require GLib master or use #ifdef GLIB_CHECK_VERSION(2,32,0)
Comment 6 Colin Walters 2011-10-19 16:10:07 UTC 
Review of attachment 199302 [details] [review]:

Yep
Comment 7 Colin Walters 2011-10-19 16:12:13 UTC 
Review of attachment 199303 [details] [review]:

There was probably a reason we were retrieving the "this" object...probably to print it?  Might be nice to try resurrecting that if it was accidentally deleted.
Comment 8 Jasper St. Pierre (not reading bugmail) 2011-10-19 16:38:52 UTC 
Attachment 199301 [details] pushed as b3cfcce - value.c: Don't use deprecated gvalue calls
Attachment 199302 [details] pushed as ed604d0 - console.c: Don't use deprecated g_thread_init()
Attachment 199303 [details] pushed as eadfba2 - stack.c: Kill a gcc unused variable warning


Fixed up configure.ac. Last patch passed IRC review (git log showed this_obj was never used).

Thanks!