After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662063 - warning: variables set but not used
warning: variables set but not used
Status: RESOLVED FIXED
Product: planner
Classification: Other
Component: General
0.14.x
Other Linux
: Normal trivial
: ---
Assigned To: Alexandre Franke
planner-maint
Depends on:
Blocks:
 
 
Reported: 2011-10-18 05:11 UTC by Tinggong Wang
Modified: 2011-12-25 02:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix warning: variable 'cmd' set but not used (18.64 KB, patch)
2011-10-18 05:12 UTC, Tinggong Wang 		committed Details | Review
after fixed 'cmd' variable, all unused variables are fixed now. (32.32 KB, patch)
2011-10-18 05:13 UTC, Tinggong Wang 		committed Details | Review

Description Tinggong Wang 2011-10-18 05:11:13 UTC 
warning: variables set but not used

after fixed 'priv' variable, other unused variables are founded.

warnings show up in building, current master tree, the latest commit is
5c961312d40f9092f4d7b10e02e018e0912957c7
Comment 1 Tinggong Wang 2011-10-18 05:12:11 UTC 
Created attachment 199299 [details] [review]
Fix warning: variable 'cmd' set but not used

Fix warning: variable 'cmd' set but not used
Comment 2 Tinggong Wang 2011-10-18 05:13:55 UTC 
Created attachment 199300 [details] [review]
after fixed 'cmd' variable, all unused variables are fixed now.

after fixed 'cmd' variable, all unused variables are fixed now.
Comment 3 Alexandre Franke 2011-11-18 10:47:40 UTC 
Review is in progress.
Comment 4 Alexandre Franke 2011-12-25 01:52:47 UTC 
Review of attachment 199299 [details] [review]:

This patch is good, I'm pushing it with a slight change (see rest of review).

::: src/planner-default-week-dialog.c
@@ +537,3 @@
 default_week_cmd_edit_free (PlannerCmd *cmd_base)
 {
+/* FIXME: cmd_base not freed

It would be nice to actually fix this.

::: src/planner-task-dialog.c
@@ +1076,3 @@
+
+	TaskCmdEditNote __attribute__ ((unused)) *cmd;
+

This is not the right way to fix this. I'm doing it another way and pushing that right after your patches.
Comment 5 Alexandre Franke 2011-12-25 02:23:08 UTC 
Review of attachment 199300 [details] [review]:

Ok too, I'm pushing it as well.
Comment 6 Alexandre Franke 2011-12-25 02:54:26 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report and your patches.