After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662031 - media-export: Deactivate on slow Tracker start-up
media-export: Deactivate on slow Tracker start-up
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: MediaExport plugin
unspecified
Other All
: Normal normal
: ---
Assigned To: Jens Georg
Zeeshan Ali
Depends on:
Blocks:
 
 
Reported: 2011-10-17 19:32 UTC by Jens Georg
Modified: 2011-10-20 17:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
media-export: Deactivate on slow Tracker start-up (3.55 KB, patch)
2011-10-17 19:32 UTC, Jens Georg
needs-work Details | Review
media-export: Deactivate on slow Tracker start-up (3.58 KB, patch)
2011-10-18 06:48 UTC, Jens Georg
accepted-commit_now Details | Review
media-export: Deactivate on slow Tracker start-up (3.55 KB, patch)
2011-10-20 17:08 UTC, Jens Georg
committed Details | Review

Description Jens Georg 2011-10-17 19:32:33 UTC
Automatic shutdown was not working under some circumstances
Comment 1 Jens Georg 2011-10-17 19:32:35 UTC
Created attachment 199257 [details] [review]
media-export: Deactivate on slow Tracker start-up

If the startup of the Tracker plug-in is delayed (e.g. due to DBus
activation) the old method of disabling MediaExport did not work since
the Tracker plug-in was not active when MediaExport was loaded. The
plug-in now listens to notify::active of the Tracker plug-in and
deactivates itself once that changes to "true".
Comment 2 Zeeshan Ali 2011-10-17 19:37:37 UTC
Review of attachment 199257 [details] [review]:

Looks good otherwise.

::: src/plugins/media-export/rygel-media-export-plugin.vala
@@ +66,3 @@
 }
 
+public void shutdown_media_export () {

this should be private and at the bottom?
Comment 3 Jens Georg 2011-10-18 06:48:58 UTC
Created attachment 199311 [details] [review]
media-export: Deactivate on slow Tracker start-up

If the startup of the Tracker plug-in is delayed (e.g. due to DBus
activation) the old method of disabling MediaExport did not work since
the Tracker plug-in was not active when MediaExport was loaded. The
plug-in now listens to notify::active of the Tracker plug-in and
deactivates itself once that changes to "true".
Comment 4 Zeeshan Ali 2011-10-20 16:47:34 UTC
Review of attachment 199311 [details] [review]:

Great!
Comment 5 Jens Georg 2011-10-20 17:08:25 UTC
The following fix has been pushed:
1f2f3fd media-export: Deactivate on slow Tracker start-up
Comment 6 Jens Georg 2011-10-20 17:08:28 UTC
Created attachment 199556 [details] [review]
media-export: Deactivate on slow Tracker start-up

If the startup of the Tracker plug-in is delayed (e.g. due to DBus
activation) the old method of disabling MediaExport did not work since
the Tracker plug-in was not active when MediaExport was loaded. The
plug-in now listens to notify::active of the Tracker plug-in and
deactivates itself once that changes to "true".