After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662011 - shell-recorder-src: Statically init mutexes instead of using the deprecated API
shell-recorder-src: Statically init mutexes instead of using the deprecated API
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-10-17 15:18 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2011-10-18 20:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shell-recorder-src: Statically init mutexes instead of using the deprecated API (2.47 KB, patch)
2011-10-17 15:18 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
Drop deprecated g_thread_init call (1.15 KB, patch)
2011-10-17 15:22 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2011-10-17 15:18:55 UTC 
see patch.
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-10-17 15:18:57 UTC 
Created attachment 199222 [details] [review]
shell-recorder-src: Statically init mutexes instead of using the deprecated API
Comment 2 Jasper St. Pierre (not reading bugmail) 2011-10-17 15:22:14 UTC 
Created attachment 199223 [details] [review]
Drop deprecated g_thread_init call

GThread will automatically initialize at program start now.
Comment 3 drago01 2011-10-18 19:14:41 UTC 
Review of attachment 199222 [details] [review]:

Just store the pointer instead of having &src->mutex all over the place.
Comment 4 drago01 2011-10-18 19:14:56 UTC 
Review of attachment 199223 [details] [review]:

Looks good.
Comment 5 Jasper St. Pierre (not reading bugmail) 2011-10-18 20:36:13 UTC 
des# Bug 662011 - shell-recorder-src: Statically init mutexes instead of using the deprecated API - NEW

Attachment 199222 [details] pushed as 338ba10 - shell-recorder-src: Statically init mutexes instead of using the deprecated API
Attachment 199223 [details] pushed as 4bb48e5 - Drop deprecated g_thread_init call