After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661953 - Modernize autotools configuration
Modernize autotools configuration
Status: RESOLVED OBSOLETE
Product: GIMP
Classification: Other
Component: General
git master
Other All
: Normal normal
: 3.0
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2011-10-17 01:40 UTC by Javier Jardón (IRC: jjardon)
Modified: 2018-05-24 13:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use upstream gettext (8.25 KB, patch)
2011-10-17 01:40 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Use autoreconf instead custom script (9.20 KB, patch)
2011-10-17 01:40 UTC, Javier Jardón (IRC: jjardon) 		needs-work Details | Review
Use upstream gettext.v2 (57.08 KB, patch)
2011-10-17 11:58 UTC, Javier Jardón (IRC: jjardon) 		needs-work Details | Review

Description Javier Jardón (IRC: jjardon) 2011-10-17 01:40:35 UTC 
Created attachment 199165 [details] [review]
Use upstream gettext

Patches following
Comment 1 Javier Jardón (IRC: jjardon) 2011-10-17 01:40:59 UTC 
Created attachment 199166 [details] [review]
Use autoreconf instead custom script
Comment 2 Michael Natterer 2011-10-17 06:24:09 UTC 
Doesn't upstream gettext finally have a way to handle multiple
po/ directories properly?
Comment 3 Javier Jardón (IRC: jjardon) 2011-10-17 11:57:13 UTC 
(In reply to comment #2)
> Doesn't upstream gettext finally have a way to handle multiple
> po/ directories properly?

yea, you have to modify a variable in po*/Makevars file. New patch attached.
Comment 4 Javier Jardón (IRC: jjardon) 2011-10-17 11:58:16 UTC 
Created attachment 199185 [details] [review]
Use upstream gettext.v2
Comment 5 Michael Natterer 2011-10-17 17:35:10 UTC 
Very nice :) However it should use $(PACKAGE)-libgimp etc.
Also, po-tags seems to miss. I also don't understand how
Makefile.in.in is going to be copied to the other po-foo/
directories, maybe we need to cp them explicitly in autogen,sh?
I also notice the Makevars has significantly less --keyword
options than the existing Makefile.in.in, and shouldn't it
use $(top_builddir) instead of ..?
Comment 6 Michael Schumacher 2014-12-26 13:58:27 UTC 
Javier, can you have a look at those questions?
Comment 7 Michael Schumacher 2015-05-23 12:03:39 UTC 
So, aynthing going to happen with these changes for 2.10?
Comment 8 Michael Natterer 2015-05-24 16:46:23 UTC 
I think we should look into both patches, but someone needs to find the
time that the new way does everything the old stuff did.
Comment 9 Michael Schumacher 2016-05-29 07:50:20 UTC 
Comment on attachment 199166 [details] [review]
Use autoreconf instead custom script

Based on recent comments.
Comment 10 Michael Schumacher 2016-05-29 07:50:38 UTC 
Comment on attachment 199185 [details] [review]
Use upstream gettext.v2

Based on recent comments.
Comment 11 Michael Schumacher 2016-05-29 09:00:25 UTC 
Given that this drops e.g. LIBTOOL_WIN32_REQUIRED_VERSION=2.2, we seem to lose the ability to require different minimal versions of tools for specific platforms.
Comment 12 Jehan 2017-03-21 15:14:57 UTC 
Shouldn't we push this to 3.0 milestone? Updating the build system is cool, but hardly a blocker and would clean out the list.
Comment 13 Jehan 2017-03-24 01:48:30 UTC 
Pushing to 3.0 milestone.
Of course feel free to provide an updated patch before we release 2.10. It may still make it.
Comment 14 GNOME Infrastructure Team 2018-05-24 13:04:30 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp/issues/381.