After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661942 - Don't autostart desktop in Xfce or KDE
Don't autostart desktop in Xfce or KDE
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Desktop
0.x.x [obsolete]
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 666218 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-10-16 22:38 UTC by Balló György
Modified: 2011-12-19 09:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Autostart only in GNOME and Unity (760 bytes, patch)
2011-10-16 22:38 UTC, Balló György
reviewed Details | Review
Autostart only in GNOME and Unity (640 bytes, patch)
2011-10-18 09:02 UTC, Balló György
committed Details | Review

Description Balló György 2011-10-16 22:38:17 UTC
Created attachment 199152 [details] [review]
Autostart only in GNOME and Unity

Don't show desktop icons in other DEs, e.g Xfce and KDE uses it's own desktop implementation. Also add some better name and comment.
Comment 1 Cosimo Cecchi 2011-10-18 02:47:35 UTC
Review of attachment 199152 [details] [review]:

Sounds okay. I inlined a comment for the patch below.

::: data/nautilus-autostart.desktop.in
@@ +2,3 @@
 Type=Application
+Name=Show desktop icons
+Comment=Draw the icons on the desktop

Please keep 'Files' as it is and remove the comment (it would have needed to be _Name and _Comment anyway for translations).
Comment 2 Balló György 2011-10-18 09:02:53 UTC
Created attachment 199313 [details] [review]
Autostart only in GNOME and Unity

Name reverted, and comment removed.

However, I think that a (translated) comment would be useful for users, who want to know the purpose of autostart file in gnome-session-properties.
Comment 3 Cosimo Cecchi 2011-10-18 16:17:20 UTC
Comment on attachment 199313 [details] [review]
Autostart only in GNOME and Unity

Attachment 199313 [details] pushed as 5208c1c - Autostart only in GNOME and Unity

Pushed this to master.
Comment 4 Cosimo Cecchi 2011-10-18 16:21:48 UTC
(In reply to comment #2)
> Created an attachment (id=199313) [details] [review]
> Autostart only in GNOME and Unity
> 
> Name reverted, and comment removed.

Thanks, I pushed this patch to git master.

> However, I think that a (translated) comment would be useful for users, who
> want to know the purpose of autostart file in gnome-session-properties.

There are various reasons why I wanted to keep it that way:
- those desktop files are not meant to be showed anywhere, really, so those strings would just be additional work for translators.
- I consider the fact that we use an autostart desktop file is just an implementation detail, and having that enabled in gnome-session-properties is not sufficient for having desktop icons visible anyway (you need to set the gsettings key)
- gnome-session-properties is not something we promote to end users as a tool to customize stuff (e.g. it doesn't have a desktop file), and is basically a big "please break my session" hammer :)
Comment 5 Cosimo Cecchi 2011-12-19 09:21:01 UTC
*** Bug 666218 has been marked as a duplicate of this bug. ***