After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661929 - Some library sources include gi18n.h incorrectly
Some library sources include gi18n.h incorrectly
Status: RESOLVED FIXED
Product: gcr
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-10-16 20:35 UTC by Gabor Kelemen
Modified: 2019-02-22 11:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Trivial patch, (1.73 KB, patch)
2011-10-16 20:48 UTC, Gabor Kelemen 		none Details | Review

Description Gabor Kelemen 2011-10-16 20:35:54 UTC 
There are a few files in gcr that include the gi18n.h header, while most files include gi18n-lib.h. As this library is going to be used by other applications, the strings from these files would be looked up in the translation files of that application, causing them to appear untranslated. Therefore all library sources should use gi18n-lib.h.
Comment 1 Gabor Kelemen 2011-10-16 20:48:11 UTC 
Created attachment 199146 [details] [review]
Trivial patch, 

To be clear, this is against the new gcr module - I think there is no Bugzilla component for it. There are such incorrect uses if gi18n.h in the remaining parts of gnome-keyring master, but until those libraries are intended to be internal and not used by other applications, those should be fine.
Comment 2 Stef Walter 2011-10-17 05:58:11 UTC 
Thanks. Applied to gcr master.