After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661891 - Refactor transcoders
Refactor transcoders
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Zeeshan Ali
Depends on:
Blocks:
 
 
Reported: 2011-10-16 06:45 UTC by Jens Georg
Modified: 2011-10-31 08:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
core: Refactor video transcoders (16.21 KB, patch)
2011-10-16 06:45 UTC, Jens Georg 		none Details | Review
core: Refactor audio transcoders (13.32 KB, patch)
2011-10-16 06:46 UTC, Jens Georg 		none Details | Review
core: Refactor audio transcoders (13.32 KB, patch)
2011-10-16 14:48 UTC, Jens Georg 		committed Details | Review
core: Refactor video transcoders (16.21 KB, patch)
2011-10-16 14:48 UTC, Jens Georg 		committed Details | Review

Description Jens Georg 2011-10-16 06:45:19 UTC 
Introduce base classes for audio and video transcoders
Comment 1 Jens Georg 2011-10-16 06:45:22 UTC 
Created attachment 199102 [details] [review]
core: Refactor video transcoders
Comment 2 Jens Georg 2011-10-16 06:46:02 UTC 
Created attachment 199103 [details] [review]
core: Refactor audio transcoders

Share a common base class and simplify transcoder code.
Comment 3 Jens Georg 2011-10-16 14:48:50 UTC 
Created attachment 199125 [details] [review]
core: Refactor audio transcoders

Share a common base class and simplify transcoder code.
Comment 4 Jens Georg 2011-10-16 14:48:53 UTC 
Created attachment 199126 [details] [review]
core: Refactor video transcoders
Comment 5 Zeeshan Ali 2011-10-25 14:58:08 UTC 
Review of attachment 199125 [details] [review]:

Looks pretty good otherwise.

::: src/rygel/rygel-aac-transcoder.vala
@@ +34,3 @@
+    private const string CODEC = "audio/mpeg,mpegversion=4," +
+                                 "framed=true,stream-format=raw," +
+                                 /*    "level=2," + */

Use '//'

::: src/rygel/rygel-audio-transcoder.vala
@@ +25,3 @@
+
+/**
+ * Transcoder for aac stream containing mpeg 4 audio.

Update needed.
Comment 6 Zeeshan Ali 2011-10-25 14:59:48 UTC 
Review of attachment 199126 [details] [review]:

Looks good.
Comment 7 Jens Georg 2011-10-31 08:40:07 UTC 
Attachment 199125 [details] pushed as 219b6a1 - core: Refactor audio transcoders
Attachment 199126 [details] pushed as 195f309 - core: Refactor video transcoders
Comment 8 Jens Georg 2011-10-31 08:40:46 UTC 
audio transcoder patch pushed with changes mentioned in comment 5