After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661886 - Avoid vertical scrolling in the filtering rules editor dialog
Avoid vertical scrolling in the filtering rules editor dialog
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
3.2.x (obsolete)
Other Linux
: Normal enhancement
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2011-10-16 04:12 UTC by Jean-François Fortin Tam
Modified: 2015-09-10 09:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
evo patch (14.73 KB, patch)
2012-07-02 14:45 UTC, Milan Crha
committed Details | Review

Description Jean-François Fortin Tam 2011-10-16 04:12:25 UTC
In the same line of thought as 
http://jeff.ecchi.ca/blog/2011/06/24/dont-make-me-scroll/

I'd like the message filtering dialog to never require scrolling unless the size request of the dialog exceeds the available height of my screen.

Perhaps one way to do it would be to enclose the entire dialog in a single scrollable view, with the scrollable property set to false by default; then, when clicking the "Add condition" or "Add action" buttons, the dialog should calculate the total size request and figure out if it has enough space to size up. If not, activate the scrollable property.
Comment 1 Milan Crha 2012-07-02 14:45:14 UTC
Created attachment 217840 [details] [review]
evo patch

for evolution;

This makes it. I decided to not enlarge window to more than 4/5 of the screen height, which I think is a reasonable value. The patch also changes few GtkH/VBox-es to GtkGrid-s.
Comment 2 Milan Crha 2012-07-02 14:46:24 UTC
Created commit 90b80d1 in evo master (3.5.4+)
Comment 3 Milan Crha 2015-09-10 09:50:51 UTC
The change above regressed recently, the code still works, but after an initiative to ignore false GObject property change notifications (commit 2f3fbdd6) the code wasn't triggered when it should. I fixed this with:

Created commit 03327b4 in evo master (3.17.92+)