After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661781 - Configure option for allowing deprecated symbols
Configure option for allowing deprecated symbols
Status: RESOLVED FIXED
Product: clutter-gst
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-gst-maint
clutter-gst-maint
Depends on:
Blocks:
 
 
Reported: 2011-10-14 15:50 UTC by Neil Roberts
Modified: 2011-10-27 15:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
autogen: Honour the NOCONFIGURE environment variable (808 bytes, patch)
2011-10-14 15:50 UTC, Neil Roberts
committed Details | Review
configure: Use the release status define to determine default flags (2.57 KB, patch)
2011-10-14 15:50 UTC, Neil Roberts
committed Details | Review
configure: Add a --enable-deprecated option (5.36 KB, patch)
2011-10-14 15:50 UTC, Neil Roberts
rejected Details | Review

Description Neil Roberts 2011-10-14 15:50:12 UTC
Clutter-GST doesn't build against current git master of glib because
it unconditionally defines G_DISABLE_DEPRECATED and GLib has changed
the way GMutex works. Here are some patches to make it have a
configure option to optionally remove that define for people who
aren't clutter-gst developers and just want the sodding thing to
build.
Comment 1 Neil Roberts 2011-10-14 15:50:13 UTC
Created attachment 199016 [details] [review]
autogen: Honour the NOCONFIGURE environment variable

Most autogen scripts don't run the configure step if there is a
NOCONFIGURE environment variable. This is quite useful if you are
trying to do an out-of-tree build.
Comment 2 Neil Roberts 2011-10-14 15:50:16 UTC
Created attachment 199017 [details] [review]
configure: Use the release status define to determine default flags

The --enable-debug option had a special m4_define to set the default
value depending on whether the minor version of the release number
suggests this is a git build. This patch changes it to use the
clutter_gst_release_status define instead so that it by default is
enabled only for git builds. The --enable-maintainer-flags option now
uses this too.

The help strings now have some added square brackets otherwise m4
doesn't seem to expand the macro properly.
Comment 3 Neil Roberts 2011-10-14 15:50:18 UTC
Created attachment 199018 [details] [review]
configure: Add a --enable-deprecated option

This adds an option to enable deprecated symbols in dependant
libraries. By default this is enabled on non-git builds. This makes it
easier to build releases whilst steal annoying developers enough to
fix the deprecations.

The MAINTAINER_CFLAGS and DEBUG_CFLAGS substitutions have been merged
into a single CLUTTER_GST_EXTRA_CFLAGS option which the deprecated
option now also uses.
Comment 4 Matthias Clasen 2011-10-17 12:29:53 UTC
now that we get compiler warnings for deprecated symbols, there is no particularly good reason to ever define G_DISABLE_DEPRECATED for detecting use of deprecated symbols.

You can still break your build if you combine -Wdeprecated-declarations with -Werror, if that's your desire.
Comment 5 Damien Lespiau 2011-10-27 15:52:24 UTC
Comment on attachment 199018 [details] [review]
configure: Add a --enable-deprecated option

I just removed the *DISABLE_DEPRECATED defines as we now get gcc warnings