GNOME Bugzilla – Bug 661722
build failure with [-Werror=format-security]
Last modified: 2012-02-22 12:02:30 UTC
libtool: compile: gcc -DPACKAGE_NAME=\"libgnome-media-profiles\" -DPACKAGE_TARNAME=\"libgnome-media-profiles\" -DPACKAGE_VERSION=\"3.0.0\" "-DPACKAGE_STRING=\"libgnome-media-profiles 3.0.0\"" "-DPACKAGE_BUGREPORT=\"http://bugzilla.gnome.org/enter_bug.cgi?product=libgnome-media-profiles\"" -DPACKAGE_URL=\"\" -DPACKAGE=\"libgnome-media-profiles\" -DVERSION=\"3.0.0\" -DGETTEXT_PACKAGE=\"libgnome-media-profiles\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_LOCALE_H=1 -DHAVE_LC_MESSAGES=1 -DHAVE_BIND_TEXTDOMAIN_CODESET=1 -DHAVE_GETTEXT=1 -DHAVE_DCGETTEXT=1 -DENABLE_NLS=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DGST_MAJORMINOR_QUOTED=\"0.10\" -I. -DGSEAL_ENABLE -pthread -DORBIT2=1 -I/usr/include/atk-1.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/gtk-3.0 -I/usr/include/cairo -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gstreamer-0.10 -I/usr/include/libxml2 -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -DG_LOG_DOMAIN=\"gnome-media-profiles\" -DDATADIR=\"/usr/share/libgnome-media-profiles\" -DGMP_UIDIR=\"/usr/share/libgnome-media-profiles\" -DGNOMELOCALEDIR=\"/usr/share/locale\" -I.. -g -O2 -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security -Wall -c audio-profiles-edit.c -fPIC -DPIC -o .libs/libgnome_media_profiles_3_0_la-audio-profiles-edit.o audio-profiles-edit.c: In function 'gm_audio_profiles_edit_finalize': audio-profiles-edit.c:742:24: warning: variable 'dialog' set but not used [-Wunused-but-set-variable] audio-profiles-edit.c: In function 'gm_audio_profiles_edit_new_profile': audio-profiles-edit.c:915:7: error: format not a string literal and no format arguments [-Werror=format-security] cc1: some warnings being treated as errors make[2]: *** [libgnome_media_profiles_3_0_la-audio-profiles-edit.lo] Fehler 1 make[2]: Leaving directory `/home/michael/debian/build-area/libgnome-media-profiles-3.0.0/libgnome-media-profiles' make[1]: *** [all-recursive] Fehler 1 make[1]: Leaving directory `/home/michael/debian/build-area/libgnome-media-profiles-3.0.0' make: *** [debian/stamp-makefile-build] Fehler 2
Created attachment 198982 [details] [review] [PATCH] Fix build failure with [-Werror=format-security]
Review of attachment 198982 [details] [review]: looks fine
Michael: Are you going to commit this?
http://git.gnome.org/browse/libgnome-media-profiles/commit/?id=1451acdacb11fdc2eb23fce10a9affa844f9527c