Created attachment 198972 [details] [review]
libmenu: Add support for keywords in .desktop files

System Settings supports X-GNOME-Keywords in .desktop files. This
should be generally useful for search (e.g. in gnome-shell), so we
should encourage application developers to add keywords and expose
the functionality in gmenu.

Review of attachment 198972 [details] [review]:

::: libmenu/desktop-entries.c
@@ +261,3 @@
+  key_file = g_key_file_new ();
+
+  if (!g_key_file_load_from_file (key_file, entry->path, 0, &error))

We don't want to parse the keyfile with GKeyFile in gnome-menus. Please add API in GDesktopAppInfo for this.

Created attachment 199001 [details] [review]
libmenu: Add support for keywords in .desktop files

(In reply to comment #2)
> We don't want to parse the keyfile with GKeyFile in gnome-menus. Please add API
> in GDesktopAppInfo for this.

OK. Not sure that support for a non-standard field will be considered acceptable, but worth a try (filed as bug 661763)

Quick follow-up:
The GIO patch has been committed, and as a result I don't really need the addition in gmenu for gnome-shell - should I just close as NOTABUG?

Let's close, yes :-)