After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661700 - rhythmbox fails to inhibit/uninhibit the gnome-session while playing a file.
rhythmbox fails to inhibit/uninhibit the gnome-session while playing a file.
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: playback
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-10-13 17:54 UTC by Ulf Winkelvos
Modified: 2011-10-16 17:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
connect to session bus instead of system bus and call the correct uninhibit method (1.29 KB, patch)
2011-10-13 17:54 UTC, Ulf Winkelvos 		none Details | Review

Description Ulf Winkelvos 2011-10-13 17:54:14 UTC 
Created attachment 198961 [details] [review]
connect to session bus instead of system bus and call the correct uninhibit method

steps to reproduce:

1) play a file with rythmbox
2) verify the session is not inhibited: 
gdbus call --session --dest org.gnome.SessionManager --object-path /org/gnome/SessionManager --method org.gnome.SessionManager.IsInhibited 15
(false,)

bugs:
1) rb-power-manager-plugin connects to dbus system bus, where it can not call Inhibit, as that method is provided by gnome-session on the session bus.
2) the method name for uninhibit changed from "UnInhibit" to "Uninhibit"

patch:
the attached patch works for me. There is a TODO as a do not really see any reason, why these errors should be ignored.
Comment 1 Ulf Winkelvos 2011-10-13 18:04:16 UTC 
well... forget about bug 2 relating the uninhibit naming... that was banshee not rhythmbox! :) 

Cheers, Ulf
Comment 2 Jonathan Matthew 2011-10-13 22:25:10 UTC 
Relevant part pushed as commit 3a3d2dd, thanks.  Please try to remove debug code and other unnecessary stuff before attaching patches.
Comment 3 Ulf Winkelvos 2011-10-16 17:57:18 UTC 
thanks for the quick response. I thougth the debug messages might be usefull at that point, but i probably should have put them in a seperate patch.