After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661651 - Preference dialog has wrong layout.
Preference dialog has wrong layout.
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
git master
Other Linux
: Normal trivial
: 3.4
Assigned To: Patricia Santana Cruz
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-10-13 11:48 UTC by Chris Kühl
Modified: 2011-10-19 20:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Changed preferences' dialog layout (53.35 KB, patch)
2011-10-19 14:49 UTC, Patricia Santana Cruz 		committed Details | Review

Description Chris Kühl 2011-10-13 11:48:57 UTC 
The spacing between the combo boxes does not comply with the HIG.
Comment 1 David King 2011-10-13 11:56:47 UTC 
The guidelines (and reasoning) are at:

http://developer.gnome.org/hig-book/stable/design-window.html.en#window-layout-spacing
Comment 2 Patricia Santana Cruz 2011-10-19 10:18:45 UTC 
I am already working on this and also taking care of the layout of this dialog in general, porting it to a new one based on grid containers.
Comment 3 Patricia Santana Cruz 2011-10-19 14:49:50 UTC 
Created attachment 199441 [details] [review]
Changed preferences' dialog layout
Comment 4 Patricia Santana Cruz 2011-10-19 14:51:36 UTC 
This should fix the bug.
Comment 5 David King 2011-10-19 20:50:54 UTC 
Comment on attachment 199441 [details] [review]
Changed preferences' dialog layout

I pushed a slightly modified patch to master as commit c4282cd0dbde3764101351055ce61317a25b4956. I removed the n_rows and n_columns properties of the grids (Glade erroneously adds these) and added a reference to this bug to the commit message. Thanks!