After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661500 - Display map in tooltip
Display map in tooltip
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Geolocation
2.33.x
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
empathy-maint
Depends on: 661501
Blocks:
 
 
Reported: 2011-10-11 22:23 UTC by Guillaume Desmottes
Modified: 2011-12-22 15:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
individual_grid_destroy: remove the ChamplainEmbedView from its container (1.23 KB, patch)
2011-12-22 12:31 UTC, Guillaume Desmottes 		committed Details | Review
Check for champlain 0.12.1 (1.13 KB, patch)
2011-12-22 12:31 UTC, Guillaume Desmottes 		committed Details | Review
individual-widget: display champlain map in tooltips (1.10 KB, patch)
2011-12-22 12:31 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2011-10-11 22:23:44 UTC 
We used to not display champlain maps in tooltips because Clutter wasn't support it ages ago. I did some quick tests and it seemed to work mostly fine, modulo bugs which should be fixed.
Comment 1 Guillaume Desmottes 2011-10-11 22:30:37 UTC 
Branch is http://cgit.collabora.com/git/user/cassidy/empathy/log/?h=map-tooltip-661500 if you want to give it a shot.

I hit this champlain bug while testing: bug #661501
Comment 2 Guillaume Desmottes 2011-12-22 12:31:05 UTC 
Created attachment 204083 [details] [review]
individual_grid_destroy: remove the ChamplainEmbedView from its container

The EmpathyIndividualWidget object is re-used for tooltips so we should remove
the ChamplainEmbedView before trying to add a new one.
Comment 3 Guillaume Desmottes 2011-12-22 12:31:08 UTC 
Created attachment 204084 [details] [review]
Check for champlain 0.12.1

We don't strictly depend on it but maps in tooltips will crash as hell with
any previous version.
Comment 4 Guillaume Desmottes 2011-12-22 12:31:11 UTC 
Created attachment 204085 [details] [review]
individual-widget: display champlain map in tooltips
Comment 5 Guillaume Desmottes 2011-12-22 15:24:37 UTC 
Attachment 204083 [details] pushed as 3712762 - individual_grid_destroy: remove the ChamplainEmbedView from its container
Attachment 204084 [details] pushed as 28e7dfc - Check for champlain 0.12.1
Attachment 204085 [details] pushed as b8249ce - individual-widget: display champlain map in tooltips