After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661490 - Should mark contacts from the "Starred in Android" group as Favorites
Should mark contacts from the "Starred in Android" group as Favorites
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: e-d-s backend
git master
Other Linux
: Normal enhancement
: Unset
Assigned To: folks-maint
folks-maint
Depends on: 665083
Blocks:
 
 
Reported: 2011-10-11 20:15 UTC by Guillaume Desmottes
Modified: 2012-07-22 12:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Tie favourite status to “Starred in Android” group for Google Contacts (7.36 KB, patch)
2012-01-09 13:21 UTC, Philip Withnall
committed Details | Review

Description Guillaume Desmottes 2011-10-11 20:15:00 UTC
This is a magic group created by Android; we should consider those contacts as favorites. See bug #660281 for details.
Comment 1 Philip Withnall 2011-10-16 08:34:11 UTC
This group comes from Google Contacts, right? (I don't have an Android phone to test this with.)
Comment 2 Guillaume Desmottes 2011-10-17 07:46:48 UTC
Me neither but yeah I think so (assuming I understand Travis comments correctly on bug #660281).
Comment 3 Travis Reitter 2011-10-17 22:42:49 UTC
(In reply to comment #1)
> This group comes from Google Contacts, right? (I don't have an Android phone to
> test this with.)

Correct - Android phones (at least, mine) mark favorite contacts in Google Contacts like that.
Comment 4 Philip Withnall 2011-11-28 20:28:04 UTC
See bug #665083 for a potential cleanup of system group stuff.
Comment 5 Philip Withnall 2011-12-06 19:52:11 UTC
EDS backend bug then.
Comment 6 Philip Withnall 2012-01-09 13:21:33 UTC
Created attachment 204862 [details] [review]
Tie favourite status to “Starred in Android” group for Google Contacts

https://www.gitorious.org/folks/folks/commits/661490-android-favourites
Comment 7 Guillaume Desmottes 2012-03-19 14:06:48 UTC
Review of attachment 204862 [details] [review]:

++
Comment 8 Philip Withnall 2012-03-19 18:54:34 UTC
Comment on attachment 204862 [details] [review]
Tie favourite status to “Starred in Android” group for Google Contacts

commit dcf663dd9100b1ef1e52fdc6e2decdaf21a1332b
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Mon Jan 9 13:18:56 2012 +0000

    eds: Tie favourite status to “Starred in Android” group for Google Contacts
    
    Link is-favourite to whether a “Starred in Android” group exists on a contact
    (and vice-versa) if the contact is from a Google Contacts address book.
    
    Closes: https://bugzilla.gnome.org/show_bug.cgi?id=661490

 NEWS                                     |    2 +
 backends/eds/lib/edsf-persona-store.vala |   50 +++++++++++++++++++++++++++
 backends/eds/lib/edsf-persona.vala       |   54 ++++++++++++++++++++++++++++++
 3 files changed, 106 insertions(+), 0 deletions(-)
Comment 9 Nirbheek Chauhan 2012-05-25 09:50:30 UTC
Is the patch supposed to hide the "Starred in Android" group after it adds all the contacts from that group to the "Favourites" group? Because right now I have both groups, and the "Starred in Android" group is completely useless because the "Favourites" group is a superset of it.


If the patch doesn't hide the android group, I think it should because it just adds noise to the contacts list. If it's supposed to hide the android group, this bug should be reopened because it doesn't hide it.
Comment 10 Philip Withnall 2012-05-27 21:03:26 UTC
(In reply to comment #9)
> Is the patch supposed to hide the "Starred in Android" group after it adds all
> the contacts from that group to the "Favourites" group?

No.

> If the patch doesn't hide the android group, I think it should because it just
> adds noise to the contacts list.

That seems like a reasonable idea.

Alex, Guillaume, Travis: what do you think? Would this work well for Empathy and gnome-contacts?
Comment 11 Guillaume Desmottes 2012-05-28 08:56:59 UTC
(In reply to comment #10)
> > If the patch doesn't hide the android group, I think it should because it just
> > adds noise to the contacts list.
> 
> That seems like a reasonable idea.
> 
> Alex, Guillaume, Travis: what do you think? Would this work well for Empathy
> and gnome-contacts?

Definitely; we really want to get rid of this group. I don't think gnome-contacts display groups at all so that should be fine.
Comment 12 Alexander Larsson 2012-05-29 06:48:37 UTC
The only way we use groups in contacts atm is the magic to detect google contacts in the "Personal" group so that we can treat them as the primary contacts from google.
Comment 13 Philip Withnall 2012-06-11 13:27:11 UTC
Reopening then.
Comment 14 Philip Withnall 2012-07-22 12:06:56 UTC
commit be282dda2e2913afce09d6140f405d96001c6d4b
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Sun Jul 22 09:10:29 2012 +0100

    eds: Hide the “Starred in Android” group from the set of groups
    
    For Google address books, it’s used to determine whether a contact is a
    favourite, so needn’t be shown in the set of groups.
    
    Note that this requires commit 161faab40fa65e813ac98042ef822298dc58cfde
    from EDS in order to behave properly.
    
    See: https://bugzilla.gnome.org/show_bug.cgi?id=661490

 backends/eds/lib/edsf-persona-store.vala |   52 ++++++++------------
 backends/eds/lib/edsf-persona.vala       |   77 ++++++++++-------------------
 2 files changed, 48 insertions(+), 81 deletions(-)