GNOME Bugzilla – Bug 661490
Should mark contacts from the "Starred in Android" group as Favorites
Last modified: 2012-07-22 12:06:56 UTC
This is a magic group created by Android; we should consider those contacts as favorites. See bug #660281 for details.
This group comes from Google Contacts, right? (I don't have an Android phone to test this with.)
Me neither but yeah I think so (assuming I understand Travis comments correctly on bug #660281).
(In reply to comment #1) > This group comes from Google Contacts, right? (I don't have an Android phone to > test this with.) Correct - Android phones (at least, mine) mark favorite contacts in Google Contacts like that.
See bug #665083 for a potential cleanup of system group stuff.
EDS backend bug then.
Created attachment 204862 [details] [review] Tie favourite status to “Starred in Android” group for Google Contacts https://www.gitorious.org/folks/folks/commits/661490-android-favourites
Review of attachment 204862 [details] [review]: ++
Comment on attachment 204862 [details] [review] Tie favourite status to “Starred in Android” group for Google Contacts commit dcf663dd9100b1ef1e52fdc6e2decdaf21a1332b Author: Philip Withnall <philip@tecnocode.co.uk> Date: Mon Jan 9 13:18:56 2012 +0000 eds: Tie favourite status to “Starred in Android” group for Google Contacts Link is-favourite to whether a “Starred in Android” group exists on a contact (and vice-versa) if the contact is from a Google Contacts address book. Closes: https://bugzilla.gnome.org/show_bug.cgi?id=661490 NEWS | 2 + backends/eds/lib/edsf-persona-store.vala | 50 +++++++++++++++++++++++++++ backends/eds/lib/edsf-persona.vala | 54 ++++++++++++++++++++++++++++++ 3 files changed, 106 insertions(+), 0 deletions(-)
Is the patch supposed to hide the "Starred in Android" group after it adds all the contacts from that group to the "Favourites" group? Because right now I have both groups, and the "Starred in Android" group is completely useless because the "Favourites" group is a superset of it. If the patch doesn't hide the android group, I think it should because it just adds noise to the contacts list. If it's supposed to hide the android group, this bug should be reopened because it doesn't hide it.
(In reply to comment #9) > Is the patch supposed to hide the "Starred in Android" group after it adds all > the contacts from that group to the "Favourites" group? No. > If the patch doesn't hide the android group, I think it should because it just > adds noise to the contacts list. That seems like a reasonable idea. Alex, Guillaume, Travis: what do you think? Would this work well for Empathy and gnome-contacts?
(In reply to comment #10) > > If the patch doesn't hide the android group, I think it should because it just > > adds noise to the contacts list. > > That seems like a reasonable idea. > > Alex, Guillaume, Travis: what do you think? Would this work well for Empathy > and gnome-contacts? Definitely; we really want to get rid of this group. I don't think gnome-contacts display groups at all so that should be fine.
The only way we use groups in contacts atm is the magic to detect google contacts in the "Personal" group so that we can treat them as the primary contacts from google.
Reopening then.
commit be282dda2e2913afce09d6140f405d96001c6d4b Author: Philip Withnall <philip@tecnocode.co.uk> Date: Sun Jul 22 09:10:29 2012 +0100 eds: Hide the “Starred in Android” group from the set of groups For Google address books, it’s used to determine whether a contact is a favourite, so needn’t be shown in the set of groups. Note that this requires commit 161faab40fa65e813ac98042ef822298dc58cfde from EDS in order to behave properly. See: https://bugzilla.gnome.org/show_bug.cgi?id=661490 backends/eds/lib/edsf-persona-store.vala | 52 ++++++++------------ backends/eds/lib/edsf-persona.vala | 77 ++++++++++------------------- 2 files changed, 48 insertions(+), 81 deletions(-)