GNOME Bugzilla – Bug 661484
[dock] Popup menus don't display
Last modified: 2011-10-12 01:58:33 UTC
I have (thanks to information in bug #660952) been able to make the dock visible, however, the menus for each button in the dock doesn't exactly work. Steps to reproduce: 1. Apply the patch found in #660952 to get the dock to be visible in gnome-shell-3.2.0 2. Right click on any button in the dock. Expected outcome: A popup menu should appear, with menu items to launch a new window (among others). I'm not sure this ever worked, as 3.2.0 is the first version of gnome-shell I've ever run, but from looking at the extension source, it *should* work. Actual outcome: No popup menu appears. And what's more: if the "autohide" function is enabled, upon right-clicking any button in the dock, this feature gets disabled (and rightly so, since we wouldn't want the dock to disappear while we were mucking about in one of the menus it spawned, would we?). Because of this, the dock now won't autohide anymore. The only two workarounds are: update the org.gnome.shell.extensions.dock.autohide dconf key or restart gnome-shell. If there is any missing information I can possibly provide, let me know!
Created attachment 198828 [details] [review] Fix dockitem menus After quite a bit of messing with the source, I was able to figure out what was going on. Please find attached a patch (against current git head of gnome-shell-extensions) to make menus in the dock work again.
The change looks right, but could you attach a git-format patch[0] instead, please? [0] https://live.gnome.org/GnomeShell/Development/WorkingWithPatches
Created attachment 198830 [details] [review] Fix dockitem menus Is this better?
Created attachment 198831 [details] [review] Fix dockitem menus
Created attachment 198832 [details] [review] Fix dockitem menus
Review of attachment 198832 [details] [review]: Minor nitpicks: - git likes to strip '[foo]' prefixes, so we changed our style to 'foo:' - no full stop in subject Those can be fixed before pushing though, no need to attach another patch version. Thanks again for the patch!