After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661417 - G722 encoder is broken
G722 encoder is broken
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other Linux
: Normal normal
: 0.10.14
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-10-10 23:09 UTC by Sjoerd Simons
Modified: 2011-10-29 15:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.14 KB, patch)
2011-10-10 23:09 UTC, Sjoerd Simons 		committed Details | Review

Description Sjoerd Simons 2011-10-10 23:09:34 UTC 
Created attachment 198745 [details] [review]
proposed patch

the following pipeline:
  audiotestsrc ! ffenc_g722 ! ffdec_g722 ! pulsesink

results in broken audio. Tracked down to wrong usage of the libav api. Patch attached
Comment 1 Robert Swain 2011-10-19 12:26:39 UTC 
Review of attachment 198745 [details] [review]:

This is correct.
Comment 2 Sjoerd Simons 2011-10-20 12:38:25 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 3 Tim-Philipp Müller 2011-10-29 15:10:47 UTC 
Actually, this will only be in the 0.10.14 gst-ffmpeg, unless Edward cherry-picks it into his gst-ffmpeg pre-release branch..

 commit eb2e9f48e33b777b33ce6f86062639b8a85ecdfb
 Author: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
 Date:   Mon Oct 10 23:56:04 2011 +0100

    ffmpegenc: Pass the size of the output buffer to avcodec_encode_audio
    
    avcodec_encode_audio is documented as taking the size of the output
    buffer not the size of the input buffer.  This fixes the use of the G722
    encoder and makes the code more consistent with avconv from the libav
    source tree.