After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661386 - fix configure running on OpenBSD
fix configure running on OpenBSD
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: build
unspecified
Other OpenBSD
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2011-10-10 15:51 UTC by Robert Nagy
Modified: 2011-10-25 01:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (2.97 KB, patch)
2011-10-10 15:51 UTC, Robert Nagy 		needs-work Details | Review
New patch (1.60 KB, patch)
2011-10-18 20:22 UTC, Robert Nagy 		none Details | Review
Fix some build issues on OpenBSD (2.01 KB, patch)
2011-10-25 01:20 UTC, Matthias Clasen 		committed Details | Review

Description Robert Nagy 2011-10-10 15:51:24 UTC 
Created attachment 198720 [details] [review]
patch

1) OpenBSD does not have _POSIX_MONOTONIC_CLOCK defined so let's
   define a hack for it.

2) Use -pthreads all the time for linking.

3) On OpenBSD sys/mount.h and sys/sysctl.h requires sys/param.h
   to be included first, so let's shuffle the includes a bit.

Please comment.
Comment 1 Matthias Clasen 2011-10-11 11:36:02 UTC 
Review of attachment 198720 [details] [review]:

I don't like ifdef __OpenBSD__ littered through the code any better than ifdef __linux__.
Not sure what to do here.
Comment 2 Robert Nagy 2011-10-11 11:44:42 UTC 
Review of attachment 198720 [details] [review]:

I think what we can do here is to not care about _POSIX_MONOTONIC_CLOCK at all and use a monotonic clock if CLOCK_MONOTONIC is defined. As far as I know and see that should be enough to decide if a system supports a monotonic clock or not. There no need to check it with sysconf(). Mono does this and they are doing fine only by checking the CLOCK_MONOTONIC definition.
Comment 3 Matthias Clasen 2011-10-12 00:04:31 UTC 
Sounds ok to me
Comment 4 Dan Winship 2011-10-12 13:00:54 UTC 
Comment on attachment 198720 [details] [review]
patch

the monotonic clock stuff should be fixed now by the patch for bug 661421
Comment 5 Matthias Clasen 2011-10-13 18:35:59 UTC 
Robert, can you provide a new patch for the remaining issues ?
Comment 6 Robert Nagy 2011-10-18 20:22:08 UTC 
Created attachment 199362 [details] [review]
New patch
Comment 7 Matthias Clasen 2011-10-25 01:20:35 UTC 
The following fix has been pushed:
ba7bf09 Fix some build issues on OpenBSD
Comment 8 Matthias Clasen 2011-10-25 01:20:38 UTC 
Created attachment 199880 [details] [review]
Fix some build issues on OpenBSD

Adapt to some OpenBSD header quirks.
Patch by Robert Nagy.