After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661376 - G722 caps negotiation doesn't work propertly
G722 caps negotiation doesn't work propertly
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other Linux
: Normal normal
: 0.10.14
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-10-10 13:57 UTC by Sjoerd Simons
Modified: 2011-10-29 15:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (4.81 KB, patch)
2011-10-10 13:57 UTC, Sjoerd Simons 		reviewed Details | Review
Further specify G722 and G726 rates (1.16 KB, patch)
2011-10-10 21:09 UTC, Sjoerd Simons 		reviewed Details | Review

Description Sjoerd Simons 2011-10-10 13:57:03 UTC 
Created attachment 198715 [details] [review]
proposed patch

The following pipeline:
  audiotestsrc ! audio/x-raw-int,channels=2\;audio/x-raw-int,channels=1 !   ffenc_g722 ! fakesink 

Bails out because caps negotiation decided to use 2 channels, while ffenc_g722 only actually supports 1 channel.

Fixed in attached patch, which also improves the general caps negotiation for ffmpeg audio codecs.
Comment 1 Sjoerd Simons 2011-10-10 20:51:13 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 2 Sjoerd Simons 2011-10-10 21:07:30 UTC 
Closed the wrong one, woops
Comment 3 Sjoerd Simons 2011-10-10 21:09:21 UTC 
Created attachment 198737 [details] [review]
Further specify G722 and G726 rates
Comment 4 Robert Swain 2011-10-19 12:21:42 UTC 
Review of attachment 198715 [details] [review]:

Looks fine. I do wonder why AAC/AC-3/etc are restricted to a maximum of 6 channels, but that is a general question as this patch does not change the behaviour w.r.t. this point.
Comment 5 Robert Swain 2011-10-19 12:22:01 UTC 
Review of attachment 198737 [details] [review]:

Looks fine to me.
Comment 6 Sjoerd Simons 2011-10-20 12:38:34 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 7 Tim-Philipp Müller 2011-10-29 15:11:41 UTC 
commit b05352beee821d8634e4dfd9a20067426511b0e4
Author: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Date:   Mon Oct 10 22:04:48 2011 +0100

    ffmpegcodecmap: Further specify allowed rates for G722 and G726

commit 93b333cfea7bffb2a09e11f33bb502ab5cb0bf2f
Author: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Date:   Mon Oct 10 14:50:09 2011 +0100

    ffmpegcodecmap: Always restrict audio codec in the unfixed cases
    
    If the context isn't fixed yet or if it doesn't exist then always
    restrict the caps.
    
    Also restrict the maximum channels for G726 and G722 to 1 channel