After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661372 - Gconf aborts in D-Bus (makes dbus_message_unref(NULL) call)
Gconf aborts in D-Bus (makes dbus_message_unref(NULL) call)
Status: RESOLVED FIXED
Product: GConf
Classification: Deprecated
Component: gconf
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: GConf Maintainers
GConf Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-10-10 11:47 UTC by Jiri Klimes
Modified: 2011-10-11 17:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't crash when reply is NULL in gconf_engine_notify_remove() (846 bytes, patch)
2011-10-11 12:43 UTC, Jiri Klimes 		committed Details | Review

Description Jiri Klimes 2011-10-10 11:47:48 UTC 
The bug originally exhibited in https://bugzilla.redhat.com/show_bug.cgi?id=737923

The report contains a patch to fix the issue.
Comment 1 Jiri Klimes 2011-10-10 11:49:58 UTC 
diff --git a/gconf/gconf-dbus.c b/gconf/gconf-dbus.c
index 335bc22..9b21293 100644
--- a/gconf/gconf-dbus.c
+++ b/gconf/gconf-dbus.c
@@ -1107,7 +1107,8 @@ gconf_engine_notify_remove (GConfEngine* conf,

   g_free (namespace_section);

-  dbus_message_unref (reply);
+  if (reply != NULL)
+    dbus_message_unref (reply);
 }

 GConfValue *


There may be other places when the argument is not checked properly.
Comment 2 André Klapper 2011-10-11 12:18:31 UTC 
[Attaching patches as attachments is welcome, so they can be recognized when querying.]
Comment 3 Jiri Klimes 2011-10-11 12:43:32 UTC 
Created attachment 198782 [details] [review]
Don't crash when reply is NULL in  gconf_engine_notify_remove()
Comment 4 Rob Bradford 2011-10-11 17:40:20 UTC 
Review of attachment 198782 [details] [review]:

Integrated!
Comment 5 Rob Bradford 2011-10-11 17:43:16 UTC 
Thanks for your patch. Committed to master - should try and integrate in the next 3.2.1 release.