GNOME Bugzilla – Bug 661301
Contributions (tileset, tool)
Last modified: 2016-05-21 10:51:12 UTC
Created attachment 198645 [details] Mahjongg map in style of a road and overpass. Just released a project I made a while back (code's a little ugly still, it was quick!) to aid me in making my own maps for Mahjongg. Link here: https://github.com/logicplace/mggmap Within that, I'd like to submit the overpass map I made, if you're accepting any. It's a pretty nice map. The other map is just a joke.. If you don't wanna compile the map yourself, here's the compilation. :]
Created attachment 254308 [details] [review] Add Overpass map by Wa (logicplace)
Review of attachment 254308 [details] [review]: Sorry this got missed. I don't see any reason not to add it; it does have to wait until after we release 3.10, though. I was pretty surprised and impressed to see a GNOME Mahjongg map compiler. :)
Review of attachment 254308 [details] [review]: Actually I put the map in the wrong place; it needs to not appear beneath "Difficult." Are these maps supposed to be ordered by difficulty? If so, I wonder where should Overpass be placed.
No worries, I'm glad it's useful. :] Can't speak for difficulty of the level, though. I don't find it particularly difficult.
Created attachment 254312 [details] [review] Add Overpass map by Wa (logicplace)
Comment on attachment 254312 [details] [review] Add Overpass map by Wa (logicplace) Added towards the bottom... not being able to fully see all the playable tiles under the overpass makes it harder than it otherwise would be.
I've added Overpass in master -- thanks for your contribution! The map generation tool also looks very interesting, and I think it makes sense to either add it to our upstream repository or at least advertise it in a README file. The disadvantage of moving it upstream is that it'd be harder for you to update it (you'd have to send patches), but that might not be a big deal since it looks like you haven't touched it in a while anyway. The other disadvantage is that it'd have to be ported to Python 3 first (moving to Python 3 is a GNOME Goal). I don't think there's a significant practical difference whether we include it upstream or just link to your GitHub page, so let me know which you'd prefer. Attachment 254312 [details] pushed as d9f2608 - Add Overpass map by Wa (logicplace)
Thank you. The generation tool certainly isn't in its best possible state, as it currently can't decide when to make rects. As much as I'd like to adjust that, I don't know if I'll ever get around to it. It also needs something for overlapping tiles. I can update it for Python 3, though. In some ways I'd prefer it to stay where it is, so if people make changes to it, it'll be reflected in that repo. Unless there's a way to do that and have it upstream too, I guess a mention in the readme would be best.
That's definitely easiest. The following fix has been pushed: c41c64d Add an advertisement for the Mahjongg Map Tool
I would like to propose an educational tileset I have prepared for gnome-mahjongg (for those interested in learning Chinese) and an example of educational use: http://rosros-3.deviantart.com/art/KanXi002-610101883 RELEASED under the GPLv2