After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661287 - Screen brightness never updated to the native value, patch included
Screen brightness never updated to the native value, patch included
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: power
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: Richard Hughes
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2011-10-08 21:06 UTC by Elias T.
Modified: 2011-11-24 23:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fixes gsd-power-manager.c (969 bytes, patch)
2011-10-08 21:06 UTC, Elias T.
none Details | Review

Description Elias T. 2011-10-08 21:06:08 UTC
Created attachment 198632 [details] [review]
fixes gsd-power-manager.c

Hello,

System: Gnome 3.2, Arch Linux, Samsung NC10, Linux 3.0

I get a bunch of warning messages in my .xsession-errors 

(gnome-settings-daemon:1297): power-plugin-WARNING **: failed to restore        ...backlight to 100: out of brightness range: 100, has to be 8 -> 0

This happens every time the mode of power manager goes from `dim' to `normal'. A quick glance at your source code reveals that you initialize the undimmed brightness value to 100 at invocation of the power-manager and never update the value to the native one if there's a policy to ignore dimming. The range of brightness values on Samsung NC10 goes from 0 to 8. From what I gather, these ranges vary from system to system.

The solution is therefore to update the brightness value even if there's a policy to ignore dimming. While I cannot duplicate bug #660755, I guess this bug is related to it.

A patch is attached to this message.
__
Elias Toivanen
Comment 1 Quentin van der Brempt 2011-10-16 21:54:37 UTC
Gnome-settings-daemon was writting the same error to my .xsession-errors. Compiling gnome-settings-daemon with the attached patch solved the issue.
System: Gnome 3.2, Arch, Samsung R719, linux 3.0
Comment 2 Gary Ching-Pang Lin 2011-11-22 07:59:20 UTC
I think this issue is fixed with this commit:

http://git.gnome.org/browse/gnome-settings-daemon/commit/?id=67785fa2b1043bd5397669f92abbd210dbf23f24

It's in gnome-settings-daemon 3.2.1.
Comment 3 Bastien Nocera 2011-11-22 10:52:04 UTC
Please test with gnome-settings-daemon 3.2.1.
Comment 4 Elias T. 2011-11-22 11:35:47 UTC
(In reply to comment #3)
> Please test with gnome-settings-daemon 3.2.1.

This bug has indeed been resolved in 3.2.1 and it hasn't reappeared in 3.2.2 I'm currently using.

As far as I'm concerned, this bug is fixed.
Comment 5 Quentin van der Brempt 2011-11-24 23:31:52 UTC
I can confirm this is fixed in 3.2.2.