GNOME Bugzilla – Bug 661272
[user menu] Wrong displayed IM status
Last modified: 2011-10-09 19:24:42 UTC
- Be connected to IM - Start gnome-shell - The Shell user menu statu is 'Unavailable' while I'm still connected.
Assuming that this is with gnome-shell from git - were you disconnected the last time you 'shut down' shell?
Created attachment 198614 [details] [review] Deal with saved-im-presence being unset The default for this key is TP_CONNECTION_PRESENCE_TYPE_UNSET which doesn't make sense as a presence. When we get this key from gsettings we should define the current presence as the default one.
Review of attachment 198614 [details] [review]: Does the UNSET status potentially screw something up, or is this merely about supporting the "I started gnome-shell from another desktop for the first time while connected to telepathy" use case? In case of the former, the patch looks good, but I'm not so sure about that if the latter is the case. It's a bit weird to preserve IM status from $other_desktop once and change it after having set a "real" status from the user menu for the first time (random example: you set your status to "away" before starting the shell, but the shell has stored "available") - so if we really want to support that use case, we'll have to have different code paths for "run in the (main) desktop session" and "started from an existing desktop session".
My problem was savedPresence == UNSET and presence == AVAILABLE; so the Shell was calling set_all_requested_presences(UNSET) which was obviously failing and so the menu was never set to available. I agree that the "start Shell from another desktop" isn't really a problem but anyway we shouldn't try setting our presence to UNSET. Another option could be to change the default of key ot AVAILABLE or OFFLINE I guess.
OFFLINE sounds like the correct choice to me.
Created attachment 198635 [details] [review] default saved-im-presence ot Offline Unset is not a valid presence type so the Shell shouldn't try setting it when starting for the first time.
Review of attachment 198635 [details] [review]: Looks good, thanks! (Subject line should be fixed up to something like "Change default of saved-im-presence to Offline" before pushing)
Merged to master.