After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661215 - flacparse: fix last frame timestamp in fixed block size mode
flacparse: fix last frame timestamp in fixed block size mode
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 649474
 
 
Reported: 2011-10-07 18:43 UTC by Vincent Penquerc'h
Modified: 2011-11-07 18:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
flacparse: fix last frame timestamp in fixed block size mode (3.01 KB, patch)
2011-10-07 18:43 UTC, Vincent Penquerc'h 		committed Details | Review

Description Vincent Penquerc'h 2011-10-07 18:43:47 UTC 
flacparse: fix last frame timestamp in fixed block size mode
Comment 1 Vincent Penquerc'h 2011-10-07 18:43:50 UTC 
Created attachment 198559 [details] [review]
flacparse: fix last frame timestamp in fixed block size mode

The last block may have a different block size, so we should not
use it to scale or we'll end up with a wrong timestamp.
See comment and quote from the FLAC format documentation in the code.

Fixes looped playback of FLAC files (via about-to-finish).
Comment 2 Vincent Penquerc'h 2011-11-07 12:37:39 UTC 
commit 14a9d1d66e802271b5cfb447442f2d7197e02950
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Fri Oct 7 19:41:35 2011 +0100

    flacparse: fix last frame timestamp in fixed block size mode
    
    The last block may have a different block size, so we should not
    use it to scale or we'll end up with a wrong timestamp.
    See comment and quote from the FLAC format documentation in the code.
    
    Fixes looped playback of FLAC files (via about-to-finish).
    
    https://bugzilla.gnome.org/show_bug.cgi?id=661215