After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661155 - Fix set_qdata warning on accessing NULL gobject property
Fix set_qdata warning on accessing NULL gobject property
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: gobject
2.28.x
Other All
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
: 653007 (view as bug list)
Depends on:
Blocks: 666182
 
 
Reported: 2011-10-07 07:31 UTC by Richard Procter
Modified: 2012-02-21 11:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Do not set qdata on NULL gobjects. (384 bytes, patch)
2011-10-07 07:31 UTC, Richard Procter 		needs-work Details | Review

Description Richard Procter 2011-10-07 07:31:22 UTC 
Created attachment 198509 [details] [review]
Do not set qdata on NULL gobjects. 

pygobject_new_sunk() may be called with NULL (see pyg_value_as_pygobject()); add a guard to avoid a warning trying to set qdata on it.
Comment 1 Ivan Stankovic 2011-12-13 08:33:04 UTC 
I believe this is a duplicate of #653007.
Comment 2 johnp 2011-12-14 15:19:24 UTC 
It is, I like this patch better as it is cleaner.
Comment 3 johnp 2011-12-14 15:22:11 UTC 
Comment on attachment 198509 [details] [review]
Do not set qdata on NULL gobjects. 

There are trailing spaces that need to be removed but other than that is is good to commit
Comment 4 johnp 2011-12-14 15:22:54 UTC 
*** Bug 653007 has been marked as a duplicate of this bug. ***
Comment 5 Ivan Stankovic 2012-02-21 09:27:36 UTC 
Could anyone please commit this? Also, are there any plans
to release the next 2.28 bugfix release soon? I (and I suppose
many others still using pygobject 2.x) would very much appreciate
seeing this released.
Comment 6 Martin Pitt 2012-02-21 11:26:56 UTC 
Pushed to 2-28 branch.