After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661121 - void functions in vte.c should not return values.
void functions in vte.c should not return values.
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.30.x
Other Solaris
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-10-06 20:12 UTC by Brian Cameron
Modified: 2011-10-30 18:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch fixing issue (764 bytes, patch)
2011-10-06 20:12 UTC, Brian Cameron 		none Details | Review

Description Brian Cameron 2011-10-06 20:12:56 UTC 
Created attachment 198470 [details] [review]
patch fixing issue

The src/vte.c file will not compile on Solaris with the Sun Studio compiler because there are two void functions that return values.  The attached patch
fixes this issue.
Comment 1 Christian Persch 2011-10-06 21:39:53 UTC 
Looks fine. Please commit to vte-0-30 branch only.
Comment 2 Brian Cameron 2011-10-07 07:49:13 UTC 
Thanks.  I am sorry, but I am really swamped the next few weeks.  If a maintainer could commit this patch for me, that would be awesome.
Comment 3 Christian Persch 2011-10-30 18:12:01 UTC 
Pushed to vte-0-32 branch only. In future, please always attach git format-patch formatted patches, NOT just raw diffs!